i#111 x64: support -leaks_only -no_esp_fastpath #2164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the test failures are actually from fefc464 and some install step failure wasn't caught by the wrapper and so it marked the build as green. Going to commit this and separately try to fix the tests failures. |
derekbruening
added a commit
that referenced
this pull request
Mar 11, 2019
Until DR supports the delay-load features needed for timezone utilities used by dbghelp loading symbols, we work around a crash when the "TZ" environment variable is unset by setting it. This is a transparency violation so we should remove this once DR's private loader is improved. Issue: #2164
derekbruening
added a commit
that referenced
this pull request
Mar 11, 2019
Until DR supports the delay-load features needed for timezone utilities used by dbghelp loading symbols, we work around a crash when the "TZ" environment variable is unset by setting it. This is a transparency violation so we should remove this once DR's private loader is improved. Issue: #2164
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For x64 we do not yet have -esp_fastpath, but we want to support
-leaks_only. It uses part of the -esp_fastpath path to run a stack
zeroing loop, but it does not actually need the -esp_fastpath gencode,
so we simply remove the option check and route to the fastpath
handler.
Issue: #111, #677