Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: gcc 4.1.2 warnings with new -O #35

Closed
derekbruening opened this issue Nov 27, 2014 · 1 comment
Closed

build: gcc 4.1.2 warnings with new -O #35

derekbruening opened this issue Nov 27, 2014 · 1 comment

Comments

@derekbruening
Copy link
Contributor

From derek.br...@gmail.com on February 24, 2009 09:43:39

after r20 swapped debug build to -O, now with gcc 4.1.2 we have warnings on
all strings that are longer than the 50-char STAT_NAME_MAX_LEN:
In file included from dynamo.c:320:
./lib/statsx.h: In function 'statistics_init':
./lib/statsx.h:180: warning: value computed is not used
./lib/statsx.h:181: warning: value computed is not used
...

Original issue: http://code.google.com/p/dynamorio/issues/detail?id=35

@derekbruening
Copy link
Contributor Author

From derek.br...@gmail.com on March 06, 2009 08:47:49

fixed in r74 issue #35: build: gcc 4.1.2 warnings with new -O

  • the 50-char max is in DRgui and the stats sample so I shortened the
    offending strings (still plenty readable)

Status: Fixed

derekbruening added a commit that referenced this issue Jul 5, 2023
8 of the 13 tests on Mac AArch64 labeled "OSX" fail prior to this PR.
Here we fix the following:

+ Syscall success is indicated by the carry flag just like x86 Mac
+ Handle sigreturn with its extra parameters just like x86 Mac
+ Fix signal handler parameters
+ Fix stolen register support in signal contexts
+ Use MAP_JIT and pthread_jit_write_protect_np for +rwx gencode in tests
+ Use DYLD_LIBRARY_PATH on Mac in tests

Now all 13 tests pass:
---------------------------------------------------------------------------------------
ctest -j 5 -L OSX
 1/13 Test  #13: code_api|common.fib ................................  Passed  0.59 sec
 2/13 Test #243: code_api|libutil.frontend_test .....................  Passed  0.63 sec
 3/13 Test #231: code_api|api.ir ....................................  Passed  0.67 sec
 4/13 Test   #9: code_api|linux.sigaction.native ....................  Passed  0.25 sec
 5/13 Test  #31: code_api|linux.signal0000 ..........................  Passed  0.10 sec
 6/13 Test #240: code_api|api.ir-static .............................  Passed  0.34 sec
 7/13 Test #241: code_api|api.drdecode ..............................  Passed  0.38 sec
 8/13 Test #245: code_api|api.dis-a64 ...............................  Passed  1.15 sec
 9/13 Test #264: no_code_api,no_intercept_all_signals|linux.sigaction  Passed  0.08 sec
10/13 Test  #33: code_api|linux.signal0010 ..........................  Passed  0.34 sec
11/13 Test  #35: code_api|linux.signal0100 ..........................  Passed  0.42 sec
12/13 Test  #37: code_api|linux.signal0110 ..........................  Passed  0.45 sec
13/13 Test   #7: samples_proj .......................................  Passed  1.89 sec
100% tests passed, 0 tests failed out of 13
---------------------------------------------------------------------------------------

Issue: #5383
github-merge-queue bot pushed a commit that referenced this issue Jul 7, 2023
8 of the 13 tests on Mac AArch64 labeled "OSX" fail prior to this PR.
Here we fix the following:

+ Syscall success is indicated by the carry flag just like x86 Mac
+ Handle sigreturn with its extra parameters just like x86 Mac
+ Fix signal handler parameters
+ Fix stolen register support in signal contexts
+ Use MAP_JIT and pthread_jit_write_protect_np for +rwx gencode in tests
+ Use DYLD_LIBRARY_PATH on Mac in tests

Now all 13 tests pass:
```
---------------------------------------------------------------------------------------
$ ctest -j 5 -L OSX
 1/13 Test  #13: code_api|common.fib ................................  Passed  0.59 sec
 2/13 Test #243: code_api|libutil.frontend_test .....................  Passed  0.63 sec
 3/13 Test #231: code_api|api.ir ....................................  Passed  0.67 sec
 4/13 Test   #9: code_api|linux.sigaction.native ....................  Passed  0.25 sec
 5/13 Test  #31: code_api|linux.signal0000 ..........................  Passed  0.10 sec
 6/13 Test #240: code_api|api.ir-static .............................  Passed  0.34 sec
 7/13 Test #241: code_api|api.drdecode ..............................  Passed  0.38 sec
 8/13 Test #245: code_api|api.dis-a64 ...............................  Passed  1.15 sec
 9/13 Test #264: no_code_api,no_intercept_all_signals|linux.sigaction  Passed  0.08 sec
10/13 Test  #33: code_api|linux.signal0010 ..........................  Passed  0.34 sec
11/13 Test  #35: code_api|linux.signal0100 ..........................  Passed  0.42 sec
12/13 Test  #37: code_api|linux.signal0110 ..........................  Passed  0.45 sec
13/13 Test   #7: samples_proj .......................................  Passed  1.89 sec
100% tests passed, 0 tests failed out of 13
---------------------------------------------------------------------------------------
```
Issue: #5383
xdje42 added a commit that referenced this issue Feb 8, 2024
)

The kernel supports passing NULL for SP to clone: It means to use the SP
of the parent. Supporting this requires augmenting dynamorio_clone to
handle SP==NULL, and augmenting create_clone_record to handle SP==NULL.

Only tested X86 in this pass. Other arches deferred.

With 32-bit testing temporarily downsized, this was manually tested on
i386:
$ ctest -R clone
Test project /home/dje/upstream/i6514/build32
    Start  34: code_api|linux.clone
1/3 Test  #34: code_api|linux.clone .............   Passed    1.00 sec
    Start  35: code_api|linux.clone-pie
2/3 Test  #35: code_api|linux.clone-pie .........   Passed    0.97 sec
    Start 100: code_api|linux.clone-reset
3/3 Test #100: code_api|linux.clone-reset .......   Passed    0.97 sec
100% tests passed, 0 tests failed out of 3
Total Test time (real) =   3.03 sec

Issue #6514

---------

Co-authored-by: Yang Liu <liuyang22@iscas.ac.cn>
Co-authored-by: Derek Bruening <bruening@google.com>
Co-authored-by: Yang Hu <146036421+huyangh-430@users.noreply.github.com>
Co-authored-by: Phil Ramsey <phil.ramsey@arm.com>
Co-authored-by: Abhinav Anil Sharma <sharmaabhinav@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant