Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-window traces contain low activity at the beginning of a new window #6104

Closed
bete0 opened this issue Jun 2, 2023 · 0 comments · Fixed by #6165
Closed

Multi-window traces contain low activity at the beginning of a new window #6104

bete0 opened this issue Jun 2, 2023 · 0 comments · Fixed by #6165
Assignees

Comments

@bete0
Copy link
Contributor

bete0 commented Jun 2, 2023

Our internal tools discovered a case when creating multi-window traces, there are missing instructions in a new buffer in the new window:

     1	instrs      6952, segments      1, threads     1
     2	instrs         0, segments      0, threads     0
     3	instrs         0, segments      0, threads     0
     4	instrs         0, segments      0, threads     0
     5	instrs         0, segments      0, threads     0
     6	instrs         0, segments      0, threads     0
     7	instrs         0, segments      0, threads     0
     8	instrs         0, segments      0, threads     0
     9	instrs         0, segments      0, threads     0
    10	instrs         0, segments      0, threads     0
    11	instrs         0, segments      0, threads     0
    12	instrs         0, segments      0, threads     0
    13	instrs         0, segments      0, threads     0
    14	instrs         0, segments      0, threads     0
    15	instrs         0, segments      0, threads     0
    <...>
   290	instrs         0, segments      0, threads     0
   291	instrs         0, segments      0, threads     0
   292	instrs         0, segments      0, threads     0
   293	instrs         0, segments      0, threads     0
   294	instrs         0, segments      0, threads     0
   295	instrs   1766865, segments    240, threads     1
   296	instrs  11316277, segments   1537, threads     1
   297	instrs  11348190, segments   1541, threads     1
   298	instrs  11342445, segments   1540, threads     1
   299	instrs  11324532, segments   1538, threads     1
   <...>
   996	instrs  16444436, segments   2037, threads     1
   997	instrs  15637905, segments   1956, threads     1
   998	instrs  16135216, segments   2003, threads     1
   999	instrs  16327844, segments   2017, threads     1
  1000	instrs  14145335, segments   1825, threads     1

This was caused by a timestamp from the end of the prior window was not updated and being used in the first buffer in the new window.

github-merge-queue bot pushed a commit that referenced this issue Aug 26, 2023
Updates the timestamp in the first buffer of a new window in
multi-window traces
by refreshing the timestamp when re-starting tracing. Previously, the
timestamp in
the first buffer was coming from the end of a prior window causing low
activity at the
beginning of a new window.

Adds a unit test that fails without the fix in this change but passes
with the change.

Fixes an issue where multi-window tracing fails to write the last window
raw file.

Fixes #6104 
Fixes #6245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants