linux.signalNNN1 test failing due to non-determinism in floating point operations #6758
Assignees
Labels
Comments
abhinav92003
added a commit
that referenced
this issue
Apr 5, 2024
Fixes the slot used to save and restore FP regs at fcache enter and return events. PR #6725 adjusted the slots used during signal handling in core/unix/signal_linux_aarch64.c but did not adjust the same in fcache enter/return and attach events. Prior to that PR, the FP regs were simply stored in a contiguous manner in signal handling code and fcache enter/return routines (instead of in their respective dr_simd_t struct member), which was a bit confusing. The mismatch between slot usage in signal handling and fcache enter/return code caused failures in the signalNNN1 tests on some systems. Verified that those tests pass with this fix. Also fixes the same issue in save_priv_mcontext_helper which is used in the dr_app_start API. Unit tests for this scenario will be added as part of #6759. Issue: #5036, #6755, #5365 Fixes #6758
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Splitting out from #6755 since we're not sure how much they overlap.
In downstream systems we're seeing that the linux.signalNNN1 tests are failing due to non-determinism in the floating point result of some trig math ops. This for some reason does not affect the test run on Github Actions.
These failures started since #6725.
The text was updated successfully, but these errors were encountered: