Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update core/arch/aarch64/codec.py to work with Python 3. #3029

Merged
merged 3 commits into from May 25, 2018
Merged

Conversation

fhahn
Copy link
Contributor

@fhahn fhahn commented May 25, 2018

core/arch/aarch64/codec.py now works with Python 2 and 3.

core/arch/aarch64/codec.py now works with Python 2 and 3.

Change-Id: Ia6fcbe2b61dcc247e02721bb2a001b0f8f566f77
@fhahn fhahn requested a review from derekbruening May 25, 2018 16:15
Copy link
Contributor

@derekbruening derekbruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is short I will hold off on my next notification test until this is in to avoid this having to re-merge and re-run the tests here.

The branch name doesn't match the conventions: not worth changing now but for future branches please use the iX or iNN convention.

@derekbruening
Copy link
Contributor

There's some failure: going to go ahead w/ my email tweak since I assume this will re-run anyway

@fhahn fhahn merged commit c24bc96 into master May 25, 2018
@fhahn fhahn deleted the codec.py-py3 branch May 25, 2018 18:40
@fhahn
Copy link
Contributor Author

fhahn commented May 25, 2018

Thanks Derek, sorry about the branch naming

fhahn added a commit that referenced this pull request Jun 18, 2018
core/arch/aarch64/codec.py now works with Python 2 and 3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants