i#4318 xarch memtrace: Add library search dir #4330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new option -alt_module_dir which specifies an alternate directory in which to look for libraries in a modules.log offline drcachesim file. Hooks the option up to the opcode_mix and view tools and to raw2trace (both its standalone launcher and drcachesim frontend integration). This will be useful in general, but is needed for adding tests with checked-in raw files and binaries, where the checked-in modules.log has a hardcoded path that will never match all test environments. Adds a test that runs both raw2trace and opcode_mix on a new checked-in aarch64 raw trace (this test will evolve for future cross-arch testing, which is the reason for using aarch64). The binaries are stripped, with the two libraries "fake" binaries: libmemtrace.so is not executed, and libdynamorio.so is only used for dynamorio_sigreturn, so these are synthetic binaries (created from asm files) to keep them smaller. The tests deliberately fail on x86 and match an error message that will improve when architecture tags are added. Issue: #4318
|
The modules.log is the wrong format for Windows (need extra columns for checksum, etc. there). I'm just going to make the test UNIX-only. |
This was referenced Jun 23, 2020
…alt_module_dir_/;
derekbruening
added a commit
that referenced
this pull request
Sep 16, 2020
derekbruening
added a commit
that referenced
this pull request
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new option -alt_module_dir which specifies an alternate
directory in which to look for libraries in a modules.log offline
drcachesim file. Hooks the option up to the opcode_mix and view tools
and to raw2trace (both its standalone launcher and drcachesim frontend
integration).
This will be useful in general, but is needed for adding tests with
checked-in raw files and binaries, where the checked-in modules.log
has a hardcoded path that will never match all test environments.
Adds a test that runs both raw2trace and opcode_mix on a new
checked-in aarch64 raw trace (this test will evolve for future
cross-arch testing, which is the reason for using aarch64). The
binaries are stripped, with the two libraries "fake" binaries:
libmemtrace.so is not executed, and libdynamorio.so is only used for
dynamorio_sigreturn, so these are synthetic binaries (created from asm
files) to keep them smaller. The tests deliberately fail on x86 and
match an error message that will improve when architecture tags are
added.
Issue: #4318