i#4318 xarch memtrace: Bump version and add message for arch tags #4342
Conversation
PR #4331 commit 5d49675 added a new marker with the architecture early in a trace, enough to break the file_reader_t assumptions. The file reader was updated, but it's best to also bump the version for old binary code. Additionally, we provide a separate distinct message about a version mismatch (otherwise the error message from the old reader is the same as without the version bump). Issue: #4318
|
This will just provide a better error message on a future version bump. I think users having to update their readers to read new versions is reasonable and cleaner than jumping through hoops to make new trace features readable by old readers. Keeping old traces readable by new readers is important though and we are maintaining that. |
|
Hmm Mac is the failure and its output is truncated: xref #4223, and PR #4341 hitting that, and @abhinav92003 's workaround found in the Travis issue tracker: 18c2a9d |
This is an attempt to fix the truncated log issue for macOS on Travis. It was suggested as a workaround at travis-ci/travis-ci#8973
This reverts commit 933271f. It didn't seem to fix the truncation here.
|
Since this PR is sort of time sensitive with the version bumping that should have gone in with the prior commit I'm going to put it in with Mac red. I tried to build Mac locally but the local machine had XCode upgraded and now doesn't build: I filed #4344. Grrr. |
PR #4331 commit 5d49675 added a new marker with the architecture
early in a trace, enough to break the file_reader_t assumptions. The
file reader was updated, but it's best to also bump the version for
old binary code. Additionally, we provide a separate distinct message
about a version mismatch (otherwise the error message from the old
reader is the same as without the version bump).
Issue: #4318