i#5495: Fix drcachesim fork bug #5500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where drcachesim -offline complained about an open file across a fork. This bug blocked tracing of SPECCPU perlbench. Adds a new test of drcachesim -offline with an app that forks. As is, this matched the -satisfy_w_xor_x test regex, and I tried to make it work with that option by fixing a file close bug here. However, I did not have time to figure out another bug which I filed as #5499. I thus tightened the "fork" regex to exclude this test from -satisfy_w_xor_x. Fixes #5495
|
Grrr, the 32-bit test hits heap use from droption's C++ classes which is #4660 and doesn't have a simple solution. |
…across fork due to unsolved #4660
abhinav92003
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where drcachesim -offline complained about an open file
across a fork. This bug blocked tracing of SPECCPU perlbench.
Adds a new test of drcachesim -offline with an app that forks. As is,
this matched the -satisfy_w_xor_x test regex, and I tried to make it
work with that option by fixing a file close bug here. However, I did
not have time to figure out another bug which I filed as #5499. I
thus tightened the "fork" regex to exclude this test from
-satisfy_w_xor_x.
Fixes #5495