i#5570: Make nohide the default for static DR #5581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renames dynamorio_static_nohide to dynamorio_static and deprecates the version where we hide DR symbols using hide_symbols. Removes tobuild_static_nohide_api, since now all static libs use the nohide variant. Documents hide_symbols as unsafe because it may lead to confusing linking behavior. Issue: #5570, #3348
abhinav92003
changed the title
derekbruening
approved these changes
Jul 28, 2022
dolanzhao
pushed a commit
that referenced
this pull request
Aug 1, 2022
Renames dynamorio_static_nohide to dynamorio_static and deprecates the version where we hide DR symbols using hide_symbols. Removes tobuild_static_nohide_api, since now all static libs use the nohide variant. Documents hide_symbols as unsafe because it may lead to confusing linking behavior. Issue: #5570, #3348
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames dynamorio_static_nohide to dynamorio_static and deprecates
the version where we hide DR symbols using hide_symbols.
Removes tobuild_static_nohide_api, since now all static DR builds use
the nohide variant.
Documents hide_symbols as unsafe because it may lead to
confusing linking behavior.
Issue: #5570, #3348