i#5498: Fix drutil_insert_get_mem_addr for w28 index #5649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix in PR #5511 for drutil_insert_get_mem_addr() on a w28 index register failed to use the application value in a temp register and resulted in an incorrect recorded address. The test added in that PR failed to actually check the value and so failed to catch the error. Here we augment the test to check the value by passing the recorded address and the operand to a clean call. This new test fails for the w28 case. With the included fix, it now passes. Fixes #5498
|
run arm tests |
AssadHashmi
approved these changes
Sep 13, 2022
|
I can only apologise for the tardiness of #5511, and any inconvenience this caused. I had put a placeholder How much of an impact did this have on the tracing? Was there a significant number of instances with |
Not a significant number, no: a small number, on the order of 0.1% of loads/stores. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix in PR #5511 for drutil_insert_get_mem_addr() on a w28 index register failed to use the application value in a temp register and resulted in an incorrect recorded address. The test added in that PR failed to actually check the value and so failed to catch the error.
Here we augment the test to check the value by passing the recorded address and the operand to a clean call. This new test fails for the w28 case. With the included fix, it now passes.
Fixes #5498