i#5365 Fix some tests which fail when build with -O3 #6492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- client.drsyms-test and client.drwrap-test-detach:
The tests expect to observe a certain function call a certain
sub-function but it doesn't happen when built with optimisation on
because the sub-function gets inlined.
This is fixed by marking the sub-functions as NOINLINE.
- client.drx-scattergather and client.drx-scattergather-bbdup
The test clients used with these tests count the number of
scatter/gather instructions that are expanded and print the number
at the end of the test, which gets checked against a reference
value. Building the test app with -O3 causes some code to be
auto vectorized so there are additional scatter/gather instructions
which throws off the count. I removed this tests from the sve_tests
list so it won't be built with -O3.
Issue: #5365
|
The |
AssadHashmi
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
client.drsyms-test and client.drwrap-test-detach: The tests expect to observe a certain function call a certain sub-function but it doesn't happen when built with optimisation on because the sub-function gets inlined. This is fixed by marking the sub-functions as NOINLINE.
client.drx-scattergather and client.drx-scattergather-bbdup: The test clients used with these tests count the number of scatter/gather instructions that are expanded and print the number at the end of the test, which gets checked against a reference value. Building the test app with -O3 causes some code to be auto vectorized so there are additional scatter/gather instructions which throws off the count. I removed this tests from the sve_tests list so it won't be built with -O3.
Issue: #5365