i#5365 AArch64: Change scatter/gather instructions to per-element size #6574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the scalar+vector scatter/gather instructions to use a per-element size for their memory operand and update the codec tests accordingly.
Change the vector+immediate scatter/gather instructions to use a per-element size for their memory operand and update the codec tests accordingly.
Change the scalar+scalar predicated contiguous load/store instructions to use a per-element size for their memory operand and update the codec tests accordingly.
The codec changes made in the previous patch mean we can combine some of the scalar+scalar encode/decode functions and simplify the codec.
Change the scalar+scalar replicating predicated contiguous load/store instructions to use a per-element size for their memory operand and update the codec tests accordingly.
Change the scalar+immediate predicated contiguous load/store instructions to use a per-element size for their memory operand and update the codec tests accordingly.
Update the documentation comments to reflect the IR changes.
Now that the IR uses the per-element size drx_expand_scatter_gather() will need to calculate the full memory transfer size.
Now that the SVE scatter/gather and predicated contiguous load/store instructions use per-element sizes we don't need this workaround any more.
|
x86-32 regression related to #6417. |
AssadHashmi
requested review from
AssadHashmi,
abhinav92003 and
derekbruening
AssadHashmi
approved these changes
Jan 23, 2024
derekbruening
approved these changes
Jan 23, 2024
jackgallagher-arm
deleted the
i5365-aarch64-scatter-gather-per-element-size
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the AArch64 IR consistent with x86 which already uses the per-element
transfer size for the scatter/gather memory operand size.
This changes the AArch64 codec for the scatter/gather and predicated contiguous
load/store instructions to use the per-element access size for the memory operand
instead of the maximum total transfer size that it used previously, and updates
the tests accordingly.
Issues: #5365, #5036, #6561