i#5365 AArch64: Fix tests on non 256-bit VL hardware #6652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the SVE tests are written assuming a 256-bit vector length so
that we get consistent output from the codec regardless of the hardware
vector length that the test is run on. This was previously acheived by
hard coding DynamoRIO's vector length to 256-bits when built with
BUILD_TESTS=1.
This worked fine for the codec tests (api.ir_sve, api.dis-a64-sve) but
this breaks tests such as client.drx-scattergather which need the
vector length to match the hardware.
This patch tweaks two things so that all tests should now work on all
vector lengths:
1. get_processor_specific_info() now initializes the vector length
to the correct hardware value whether or not BUILD_TESTS=1.
This enables the client tests to work on all vector lengths.
2. The AArch64 codec now uses dr_get_sve_vector_length() to get the
vector length when built with BUILT_TESTS=1. This allows the api
tests to override the vector length used by the codec by calling
dr_set_sve_vector_length().
The api tests already call enable_all_test_cpu_features() which itself
calls dr_set_sve_vector_length(256) so no changes to the tests
themselves were needed.
Issue: #5365
AssadHashmi
approved these changes
Feb 14, 2024
jackgallagher-arm
deleted the
i5365-fix-tests-on-non-256-bit-hardware
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the SVE tests are written assuming a 256-bit vector length so that we get consistent output from the codec regardless of the hardware vector length that the test is run on. This was previously acheived by hard coding DynamoRIO's vector length to 256-bits when built with BUILD_TESTS=1.
This worked fine for the codec tests (api.ir_sve, api.dis-a64-sve) but this breaks tests such as client.drx-scattergather which need the vector length to match the hardware.
This patch tweaks two things so that all tests should now work on all vector lengths:
The api tests already call enable_all_test_cpu_features() which itself calls dr_set_sve_vector_length(256) so no changes to the tests themselves were needed.
Issue: #5365