i#6685 core-shard: Add idles and waits to basic_counts #6754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds counts of idle and wait records to basic_counts, which are useful when examining core-sharded-on-disk traces. Rewords "scheduling markers" to "timestamp + cpuid markers" to clarify. Rewords "transfer markers" to "kernel transfer markers". Updates the tests; the core-serial tests non-zero output here, and the core-sharded test also manually tested non-zero output as it required removing these counts for reliable comparison of record vs replay. Issue: #6685
|
Failure is record_filter_bycore_multi due to an inaccurate pi estimate print by the app on a64 sve: #6755 |
abhinav92003
approved these changes
Apr 4, 2024
|
(waiting on an issue with PR #6725 affecting our internal tests...will merge once that is resolved) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds counts of idle and wait records to basic_counts, which are useful when examining core-sharded-on-disk traces.
Rewords "scheduling markers" to "timestamp + cpuid markers" to clarify. Rewords "transfer markers" to "kernel transfer markers".
Updates the tests; the core-serial tests non-zero output here, and the core-sharded test also manually tested non-zero output as it required removing these counts for reliable comparison of record vs replay.
Issue: #6685