i#6778: Gracefully handle too few drcachesim cpus #6779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a check with an error message for too few simulated drcachesim cpus with a core-sharded-on-disk trace. Adds a unit test which crashes without the fix. Also tested manually: Before: $ bin64/drrun -t drcachesim -indir ../src/clients/drcachesim/tests/drmemtrace.threadsig-core-sharded.x64.tracedir/ -cores 3 Segmentation fault After: $ bin64/drrun -t drcachesim -indir ../src/clients/drcachesim/tests/drmemtrace.threadsig-core-sharded.x64.tracedir/ -cores 3 ERROR: failed to run analyzer: Too-small core count 3 for trace core #3 Fixes #6778
|
win32 failure is client.detach-test timing out, which seems to happen every run now: #6764 |
|
x32 failure is opcode_mix encode size mismatch #6303 |
brettcoon
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a check with an error message for too few simulated drcachesim cpus with a core-sharded-on-disk trace.
Adds a unit test which crashes without the fix.
Also tested manually:
Before:
$ bin64/drrun -t drcachesim -indir ../src/clients/drcachesim/tests/drmemtrace.threadsig-core-sharded.x64.tracedir/ -cores 3
Segmentation fault
After:
$ bin64/drrun -t drcachesim -indir ../src/clients/drcachesim/tests/drmemtrace.threadsig-core-sharded.x64.tracedir/ -cores 3
ERROR: failed to run analyzer: Too-small core count 3 for trace core #3
Fixes #6778