Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fields: Add options for range method for Document #190

Merged
merged 1 commit into from
Sep 12, 2017
Merged

Fields: Add options for range method for Document #190

merged 1 commit into from
Sep 12, 2017

Conversation

richardhsu
Copy link
Collaborator

  • [Update] Allow passing options to range when defining attributes
    of the document. Current options mainly for serialized fields and
    passing the serializer option.

Fields: Add options for range method for Document
6e0d6a2 
- [Update] Allow passing options to `range` when defining attributes
  of the document. Current options mainly for serialized fields and
  passing the `serializer` option.
@coveralls
Copy link

coveralls commented Sep 11, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.05%) to 96.858% when pulling 6e0d6a2 on richardhsu:richardhsu/range-field-with-options into 70e2fe3 on Dynamoid:master.

pboling
pboling approved these changes Sep 12, 2017
View reviewed changes
Copy link
Member

@pboling pboling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I don't understand why it says code coverage dropped, but same number of lines as before and you added tests. :/

@pboling pboling merged commit a33de98 into Dynamoid:master Sep 12, 2017
@richardhsu richardhsu deleted the richardhsu/range-field-with-options branch September 12, 2017 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pboling pboling pboling approved these changes

@andrykonchin andrykonchin Awaiting requested review from andrykonchin

Assignees

@pboling pboling

@andrykonchin andrykonchin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@richardhsu @coveralls @pboling @andrykonchin