Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dynamoid::Criteria::Chain#key_present? #204

Merged
merged 1 commit into from Nov 2, 2017
Merged

Fix Dynamoid::Criteria::Chain#key_present? #204

merged 1 commit into from Nov 2, 2017

Conversation

andrykonchin
Copy link
Member

Fix issue with Query request.
Any non-equal condition for partition key leads to making Query operation but it should make Scan one.

Example

Document.where(:"id.in" => [])

@coveralls
Copy link

coveralls commented Nov 2, 2017

Coverage Status

Coverage increased (+0.004%) to 97.106% when pulling 639ca76 on andrykonchin:fix-scan-with-condition-on-partition-key into 01f1a3e on Dynamoid:master.

Copy link
Member

@pboling pboling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for adding a spec!

Copy link
Collaborator

@richardhsu richardhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

@andrykonchin andrykonchin merged commit 4661bdc into Dynamoid:master Nov 2, 2017
@andrykonchin andrykonchin deleted the fix-scan-with-condition-on-partition-key branch November 2, 2017 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants