Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change benchmark logging to debug #236

Merged
merged 1 commit into from Feb 16, 2018
Merged

Change benchmark logging to debug #236

merged 1 commit into from Feb 16, 2018

Conversation

kicktheken
Copy link
Contributor

@kicktheken kicktheken commented Feb 15, 2018 •
edited

It makes more sense that this should be debug level rather than info since it may log out sensitive information.

@kicktheken kicktheken closed this Feb 15, 2018
@coveralls
Copy link

coveralls commented Feb 15, 2018 •
edited

Coverage Status

Coverage remained the same at 97.429% when pulling c6a5884 on docsend:v2.0.0_benchmark-debug into 648fe1c on Dynamoid:master.

@kicktheken kicktheken reopened this Feb 15, 2018
pboling
pboling approved these changes Feb 15, 2018
View reviewed changes
Copy link
Member

@pboling pboling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Until we split out the argument logging into a separate log, or integrate an argument sanitizer, we should have this at debug level. We may want to add back the info level timing with a clean summary.

@pboling pboling merged commit dee0a6b into Dynamoid:master Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pboling pboling pboling approved these changes

@andrykonchin andrykonchin andrykonchin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kicktheken @coveralls @pboling @andrykonchin