Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Config default models_dir #238

Merged
merged 2 commits into from
Feb 19, 2018
Merged

Fix: Config default models_dir #238

merged 2 commits into from
Feb 19, 2018

Conversation

baloran
Copy link
Collaborator

@baloran baloran commented Feb 16, 2018

Change the config for :models_dir.

Refer to #237

@baloran baloran added the bug label Feb 16, 2018
@baloran baloran self-assigned this Feb 16, 2018
@coveralls
Copy link

coveralls commented Feb 16, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 97.429% when pulling 483760d on fix/require-create_tables into 34bdd39 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.429% when pulling 1f6aea2 on fix/require-create_tables into 34bdd39 on master.

@baloran baloran closed this Feb 16, 2018
@baloran baloran deleted the fix/require-create_tables branch February 16, 2018 17:41
@andrykonchin
Copy link
Member

andrykonchin commented Feb 17, 2018 •
edited
Loading

Actually it makes sense to merge this change. Current default value doesn't work well with Rails...

@baloran baloran restored the fix/require-create_tables branch February 18, 2018 13:08
@baloran baloran reopened this Feb 18, 2018
@baloran
Copy link
Collaborator Author

baloran commented Feb 19, 2018

I merge ?

pboling
pboling approved these changes Feb 19, 2018
View reviewed changes
Copy link
Member

@pboling pboling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pboling pboling merged commit 21308a6 into master Feb 19, 2018
@pboling pboling deleted the fix/require-create_tables branch February 19, 2018 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pboling pboling pboling approved these changes

@andrykonchin andrykonchin andrykonchin approved these changes

Assignees

@baloran baloran

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@baloran @coveralls @andrykonchin @pboling