Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to pass empty strings and sets to .import method #244

Merged
merged 1 commit into from Mar 13, 2018
Merged

Allow to pass empty strings and sets to .import method #244

merged 1 commit into from Mar 13, 2018

Conversation

andrykonchin
Copy link
Member

Support empty strings and sets in .import method like it's done for other persistence methods like .create and #update_attributes.

So now following example should work:

User.import([{..., last_name: ''}])

Related issue #107 (comment)

@coveralls
Copy link

coveralls commented Mar 10, 2018 •
edited

Coverage Status

Coverage increased (+0.02%) to 97.552% when pulling 77e1447 on fix-empty-strings-handling-in-import into 46b1784 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.4%) to 96.178% when pulling 02a2447 on fix-empty-strings-handling-in-import into 46b1784 on master.

@andrykonchin andrykonchin force-pushed the fix-empty-strings-handling-in-import branch from 02a2447 to 77e1447 Compare March 10, 2018 19:52
pboling
pboling approved these changes Mar 11, 2018
View reviewed changes
Copy link
Member

@pboling pboling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

richardhsu
richardhsu approved these changes Mar 13, 2018
View reviewed changes
Copy link
Collaborator

@richardhsu richardhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@pboling pboling merged commit 5343437 into master Mar 13, 2018
@pboling pboling deleted the fix-empty-strings-handling-in-import branch March 13, 2018 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pboling pboling pboling approved these changes

@richardhsu richardhsu richardhsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andrykonchin @coveralls @pboling @richardhsu