Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default time zone to UTC #279

Merged
merged 1 commit into from Jul 25, 2018
Merged

Change default time zone to UTC #279

merged 1 commit into from Jul 25, 2018

Conversation

andrykonchin
Copy link
Member

@andrykonchin andrykonchin commented Jul 24, 2018 •
edited

Default application time zone was set to local to be backward compatible.
Now it's changed.

I believe the default time zone should be UTC (like it is in Rails) and major release is right time to make this change.

It makes sense to make it equal to Rails config.time_zone by default in Rails application but maybe next time.

@coveralls
Copy link

coveralls commented Jul 24, 2018 •
edited

Coverage Status

Coverage decreased (-0.006%) to 98.432% when pulling 9b3b25e on change-default-application-timezone-to-utc into 12b874c on master.

@andrykonchin andrykonchin merged commit 6a59092 into master Jul 25, 2018
@andrykonchin andrykonchin deleted the change-default-application-timezone-to-utc branch July 25, 2018 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardhsu richardhsu richardhsu approved these changes

@pboling pboling Awaiting requested review from pboling

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrykonchin @coveralls @richardhsu