Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix consistent_read option of Finders#find #311

Merged
merged 1 commit into from Oct 31, 2018
Merged

fix consistent_read option of Finders#find #311

merged 1 commit into from Oct 31, 2018

Conversation

kokuyouwind
Copy link
Contributor

In README.md#Consistent Reads, Model#find provides consistent_read option.

Address.find(address.id, consistent_read: true) # Find an address, ensure the read is consistent.

But it does not work.

I fix this by passing consistent_read option to client in AwsSdkV3#get_item.

@kokuyouwind kokuyouwind changed the title 🐛 fix consistent_read option of Finders#find fix consistent_read option of Finders#find Oct 31, 2018
@andrykonchin
Copy link
Member

👍
Looks good

@andrykonchin andrykonchin merged commit 522731e into Dynamoid:master Oct 31, 2018
@andrykonchin andrykonchin mentioned this pull request Nov 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kokuyouwind @andrykonchin