Support Rails 6 #368
Merged
Support Rails 6 #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nged? and name_previous_change
andrykonchin
force-pushed
the
support-rails-6
branch
from
b85c3c6
to
8e78f15
Compare
andrykonchin
force-pushed
the
support-rails-6
branch
2 times, most recently
from
723ba6f
to
fdfeab7
Compare
andrykonchin
force-pushed
the
support-rails-6
branch
from
fdfeab7
to
b807868
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
previous_changesThere were conflicts with monkey-patches in Dirty module and new changes in Rails 6 Dirty module. It was decided to copy-paste Dirty module from Rails 4.2 and add some new methods from Rails 5.2.
So only implementation was changed, not interface. The only change - now Dirty interface doesn't depend on Rails version and is the same (like in Rails 5.2) on Rails 4.0 and Rails 6.0.
Related issue #366