New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for aws-sdk 2 #4
Conversation
@BilalBudhani, any feedback will be appreciated. |
I've tested this in my current project. Everything seems to be working fine at the moment. I just ran into one breaking issue which is when the field is not defined in the model but it exits in DynamoDB item then it raises a error resulting in breaking the code. This behaviour should be handled as there are chances of DynamoDB fields being out of sync with the model. It might break some legacy applications. |
@BilalBudhani, how do you suggest to handle that situation? One problem I see is that without a |
@philipmw Can we just simply ignore the |
@BilalBudhani, I must have misunderstood your original bug report. I agree that Dynamoid should ignore fields that aren't declared on the model. It sounds like you're saying that if a DynamoDB record has attributes that aren't declared on the Ruby model, Dynamoid raises an exception when materializing the model instance. Is that right? |
@philipmw Yes. When DynamoDB record has a |
@BilalBudhani would you open an issue about this? I assume this behavior exists on the master branch too. |
@philipmw Sure. I will open an issue for it. |
@philipmw, can you move your commits that remove functionality and/or fix issues other than AWS-SDK-2 to a separate PR? BTW. You can do this easily by pushing a new branch with them, then resetting the aws-sdk-2 branch back a few commits. |
@loganb, done. |
They intermittently fail because they change global state, and one of the two specs doesn't even test what it claims to.
Improve spec formatting and Travis CI testing. No functional changes.
Changes Unknown when pulling 1c8eb57 on clientv2 into ** on master**. |
I would like to get some feedback on the pull request for using aws-sdk 2. Once this pull request is accepted, the dynamoid major version should be bumped as the change is not compatible with aws-sdk 1.
In the meantime (till, I get the feedback on the pull request), I will update the README section to reflect the changes.