Proxy kwargs independently from positional args. Closes #571. #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the fix. Could you please exclude all the not relevant formatting changes (e.g. changing '' to "")? Also I think this change deserves a separate test case, not modifying the existing it "behaves like the object it is trying to be" do |
xeger
force-pushed
the
issue-571-fix-ruby3-method-proxying
branch
from
0a9e504
to
eb8329c
Compare
|
Done @andrykonchin; I also added support for proxied-method blocks and |
|
Looks good. Thank you. But there is a failed spec on old Rubies. |
|
I fixed the spec. Not a pretty fix, but an efficient one. |
xeger
force-pushed
the
issue-571-fix-ruby3-method-proxying
branch
from
28c04e7
to
0a9e504
Compare
|
Closed in favor of #573 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.