Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #increment! and #decrement! methods to behave similarly to the Rails' ActiveRecord methods #624

Merged
merged 8 commits into from
Jan 9, 2023
Merged

Fix #increment! and #decrement! methods to behave similarly to the Rails' ActiveRecord methods #624

merged 8 commits into from
Jan 9, 2023

Commits on Jan 8, 2023

  1. Fix #increment! method to behave similar to Rails' ActiveRecord 

    Changes:
- returns self, not boolean
- saves only the attribute new value, not other modified attributes
- skips callbacks and validation
- does not reload a model
    @andrykonchin
    andrykonchin committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    8cdd69e View commit details
    Browse the repository at this point in the history

  2. Fix #decrement! method to behave similar to Rails' ActiveRecord

    @andrykonchin
    andrykonchin committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    0e33b01 View commit details
    Browse the repository at this point in the history

  3. Support :touch option in the .inc method

    @andrykonchin
    andrykonchin committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    5476f0d View commit details
    Browse the repository at this point in the history

  4. Support :touch option in the #increment! method

    @andrykonchin
    andrykonchin committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    6fbef31 View commit details
    Browse the repository at this point in the history

  5. Support :touch option in the #decrement! method

    @andrykonchin
    andrykonchin committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    c3dd8ea View commit details
    Browse the repository at this point in the history

  6. Use default RubyGems and Bundler versions and do not try to update th… 

    …em to the latest ones
    @andrykonchin
    andrykonchin committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    99d937c View commit details
    Browse the repository at this point in the history

  7. Refactor #decrement and #decrement!

    @andrykonchin
    andrykonchin committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    dce3a2f View commit details
    Browse the repository at this point in the history

  8. Refactor .inc and move code to a separate class

    @andrykonchin
    andrykonchin committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    f423a3d View commit details
    Browse the repository at this point in the history