Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a configuration flag to create table on save #656

Merged
merged 1 commit into from Apr 28, 2023

Conversation

imaximix
Copy link

I've added a configuration so you can prevent table creation on save.
We manage tables with something else, so we want to avoid it in production.

I saw that there is another PR that also does this here

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #656 (c9574f4) into master (6d757f1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head c9574f4 differs from pull request most recent head 5cdfcc9. Consider uploading reports for the commit 5cdfcc9 to get more accurate results

@@           Coverage Diff           @@
##           master     #656   +/-   ##
=======================================
  Coverage   90.33%   90.34%           
=======================================
  Files          62       62           
  Lines        3157     3160    +3     
=======================================
+ Hits         2852     2855    +3     
  Misses        305      305           
Impacted Files Coverage Δ
lib/dynamoid/config.rb 90.32% <100.00%> (+0.15%) ⬆️
lib/dynamoid/persistence.rb 98.18% <100.00%> (+0.02%) ⬆️

lib/dynamoid/persistence.rb Outdated Show resolved Hide resolved
andrykonchin
andrykonchin previously approved these changes Apr 27, 2023
@andrykonchin
Copy link
Member

Could you please squash commits into a single one after CI passes successfully?

andrykonchin
andrykonchin previously approved these changes Apr 28, 2023
@andrykonchin
Copy link
Member

Thank you!

@andrykonchin andrykonchin merged commit aa790f1 into Dynamoid:master Apr 28, 2023
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants