Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unless_exists example in README.md #660

Merged
merged 4 commits into from May 27, 2023

Conversation

andrykonchin
Copy link
Member

@andrykonchin andrykonchin commented May 27, 2023

Close #657

Changes:

  • fixed example in the README file
  • documented unless_exists option of persisting methods
  • refactored and removed if_exists option, that was available but is an implementation detail and isn't documented

@codecov
Copy link

codecov bot commented May 27, 2023

Codecov Report

Merging #660 (8ca0e64) into master (c9574f4) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 8ca0e64 differs from pull request most recent head 464f115. Consider uploading reports for the commit 464f115 to get more accurate results

@@            Coverage Diff             @@
##           master     #660      +/-   ##
==========================================
- Coverage   90.34%   90.33%   -0.02%     
==========================================
  Files          62       62              
  Lines        3160     3156       -4     
==========================================
- Hits         2855     2851       -4     
  Misses        305      305              
Impacted Files Coverage Δ
lib/dynamoid/adapter_plugin/aws_sdk_v3.rb 94.21% <ø> (-0.09%) ⬇️
lib/dynamoid/config.rb 90.32% <100.00%> (ø)
lib/dynamoid/persistence.rb 98.17% <100.00%> (-0.02%) ⬇️
lib/dynamoid/persistence/save.rb 96.36% <100.00%> (ø)
lib/dynamoid/persistence/update_fields.rb 100.00% <100.00%> (ø)

@andrykonchin andrykonchin force-pushed the fix-unless-exists-example-in-readme branch from 30a8a2c to 464f115 Compare May 27, 2023 19:31
@github-actions
Copy link

Code Coverage

Package Line Rate Health
dynamoid 90%
Summary 90% (2851 / 3156)

Minimum allowed line rate is 90%

@andrykonchin andrykonchin merged commit 7896f96 into master May 27, 2023
48 of 49 checks passed
@andrykonchin andrykonchin deleted the fix-unless-exists-example-in-readme branch May 27, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conditional updates are incorrect in README
1 participant