Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #687

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Update README.md #687

merged 1 commit into from
Oct 10, 2023

Conversation

dunkOnIT
Copy link
Contributor

This PR adds a note about requiring model files when running RSpec tests, based on #277.

I believe this should be documented, as it is not obvious how included_models is set, or that it would be empty.

Added note about requiring models in RSpec tests
@andrykonchin
Copy link
Member

Thank you!

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #687 (3331b8f) into master (b2103d9) will not change coverage.
The diff coverage is n/a.

❗ Current head 3331b8f differs from pull request most recent head cf9701a. Consider uploading reports for the commit cf9701a to get more accurate results

@@           Coverage Diff           @@
##           master     #687   +/-   ##
=======================================
  Coverage   90.35%   90.35%           
=======================================
  Files          62       62           
  Lines        3162     3162           
=======================================
  Hits         2857     2857           
  Misses        305      305           

@andrykonchin andrykonchin merged commit f8fb70c into Dynamoid:master Oct 10, 2023
48 of 49 checks passed
@dunkOnIT dunkOnIT deleted the readme_update branch October 11, 2023 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants