Dynatrace · jjasghar · Apr 20, 2018
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -1,3 +1,5 @@
+inherit_from: .rubocop_todo.yml
+
 AlignParameters:
   Enabled: false
 

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -0,0 +1,17 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2018-04-20 15:39:52 -0500 using RuboCop version 0.49.1.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 7
+# Configuration parameters: CountComments, ExcludedMethods.
+Metrics/BlockLength:
+  Max: 51
+
+# Offense count: 1
+Security/MarshalLoad:
+  Exclude:
+    - 'libraries/cache_data.rb'
diff --git a/Berksfile b/Berksfile
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://supermarket.chef.io'
 
 metadata

diff --git a/Gemfile b/Gemfile
@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 group :integration do
   # Workaround: berkshell is dependent on buff-extensions gem but install older version as the new one (2.0.0) requires
   # ruby 2.2 and chefdk up to 0.17 provides ruby 2.1.8
-  gem 'buff-extensions', '~>1.0.0'
   gem 'berkshelf'
+  gem 'buff-extensions', '~>1.0.0'
   gem 'kitchen-docker', '>=2.3.0'
   gem 'kitchen-vagrant', '>=0.18.0'
   gem 'test-kitchen', '>=1.4.2'

diff --git a/attributes/agents_package.rb b/attributes/agents_package.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Attributes:: agents_package

diff --git a/attributes/apache_wsagent.rb b/attributes/apache_wsagent.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Attributes:: apache_wsagent

diff --git a/attributes/collector.rb b/attributes/collector.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Attributes:: collector

diff --git a/attributes/copy_or_download_file.rb b/attributes/copy_or_download_file.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Attributes:: copy_or_download_file

diff --git a/attributes/default.rb b/attributes/default.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Attributes:: default

diff --git a/attributes/dotnet_agent.rb b/attributes/dotnet_agent.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Attributes:: dotnet_agent

diff --git a/attributes/host_agent.rb b/attributes/host_agent.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Attributes:: host_agent

diff --git a/attributes/iis_wsagent.rb b/attributes/iis_wsagent.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Attributes:: iis_wsagent

diff --git a/attributes/java.rb b/attributes/java.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Attributes:: java

diff --git a/attributes/java_agent.rb b/attributes/java_agent.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Attributes:: java_agent

diff --git a/attributes/memory_analysis_server.rb b/attributes/memory_analysis_server.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Attributes:: memory_analysis_server

diff --git a/attributes/one_agent.rb b/attributes/one_agent.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # The Dynatrace One Agent package will be installed into the directory
 # node['dynatrace']['agents_package']['linux']['installer']['prefix_dir']/dynatrace-$major-$minor-$rev,
 # where $major, $minor and $rev are given by the installer. A symbolic link to the actual installation directory will

diff --git a/attributes/server.rb b/attributes/server.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Attributes:: server
@@ -50,7 +52,7 @@
 default['dynatrace']['server']['pwh_connection']['password'] = 'dynatrace'
 
 # Accepted HTTP return codes when setting PWH connection. Used mainly for integration tests
-default['dynatrace']['server']['pwh_connection']['success_codes'] = %w(200)
+default['dynatrace']['server']['pwh_connection']['success_codes'] = %w[200]
 
 # Set a longer boot timeout due to the time to open the collector port
 # (see log "[SelfMonitoringLauncher] Waiting for self-monitoring Collector startup (max: 90 seconds)")

diff --git a/attributes/server_update.rb b/attributes/server_update.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Attributes:: server_update

diff --git a/attributes/upgrade_system.rb b/attributes/upgrade_system.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: upgrade_system
 # Attributes:: upgrade system

diff --git a/attributes/wsagent_package.rb b/attributes/wsagent_package.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Attributes:: wsagent_package

diff --git a/libraries/cache_data.rb b/libraries/cache_data.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Libraries:: cache_data

diff --git a/libraries/endpoint_helpers.rb b/libraries/endpoint_helpers.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Libraries:: endpoint_helpers
@@ -19,9 +21,9 @@ class DynatraceTimeout < Timeout::Error; end
     # Exception used to inform that a connection endpoint (listening port, REST WS) is still not available
     class DynatraceNotReady < StandardError
       def initialize(endpoint, timeout)
-        super <<-EOH
-The Dynatrace Server at `#{endpoint}' did not become ready within #{timeout} seconds.
-Possibly, Dynatrace has failed to start. Please check your Dynatrace Server log files.
+        super <<~EOH
+          The Dynatrace Server at `#{endpoint}' did not become ready within #{timeout} seconds.
+          Possibly, Dynatrace has failed to start. Please check your Dynatrace Server log files.
 EOH
       end
     end
@@ -90,7 +92,7 @@ def self.wait_until_rest_endpoint_is_ready!(endpoint, timeout = 180)
 
     def self.rest_get(endpoint, user, pass, options = {})
       options[:accept] = options.fetch(:accept, 'application/json')
-      options[:success_codes] = options.fetch(:success_codes, %w(200))
+      options[:success_codes] = options.fetch(:success_codes, %w[200])
 
       uri = URI(endpoint)
       http = Net::HTTP.new(uri.host, uri.port)
@@ -106,7 +108,7 @@ def self.rest_get(endpoint, user, pass, options = {})
 
     def self.rest_put(endpoint, user, pass, body, options = {})
       options[:accept] = options.fetch(:accept, 'application/json')
-      options[:success_codes] = options.fetch(:success_codes, %w(200))
+      options[:success_codes] = options.fetch(:success_codes, %w[200])
 
       uri = URI(endpoint)
       http = Net::HTTP.new(uri.host, uri.port)

diff --git a/libraries/file_helpers.rb b/libraries/file_helpers.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Libraries:: file_helpers

diff --git a/libraries/package_helpers.rb b/libraries/package_helpers.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Libraries:: package_helpers

diff --git a/libraries/process_helpers.rb b/libraries/process_helpers.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Libraries:: process_helpers
@@ -53,7 +55,7 @@ def self.stop_processes(proc_pattern, proc_user, platform_family, timeout = 15,
     # private_class_method
     def self.find_pids(pattern, user, platform_family)
       pids = []
-      raise 'ERROR: Unsupported platform' unless %w(debian fedora rhel).include? platform_family
+      raise 'ERROR: Unsupported platform' unless %w[debian fedora rhel].include? platform_family
 
       pgrep_pattern_opt = !pattern.nil? ? "-f \"#{pattern}\"" : ''
       pgrep_user_opt = !user.nil? ? "-u #{user}" : ''

diff --git a/libraries/s3_helpers.rb b/libraries/s3_helpers.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Libraries:: s3_helpers

diff --git a/metadata.rb b/metadata.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 name 'dynatrace-appmon'
 maintainer 'Martin Etmajer'
 maintainer_email 'martin.etmajer@dynatrace.com'
@@ -9,7 +11,7 @@
 issues_url 'https://github.com/Dynatrace/Dynatrace-AppMon-Chef/issues'
 chef_version '>= 12.1'
 
-%w( debian ubuntu redhat centos fedora amazon windows ).each do |os|
+%w[debian ubuntu redhat centos fedora amazon windows].each do |os|
   supports os
 end
 

diff --git a/providers/configure_ini_files.rb b/providers/configure_ini_files.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Providers:: configure_ini_files

diff --git a/providers/configure_init_scripts.rb b/providers/configure_init_scripts.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Providers:: configure_init_scripts

diff --git a/providers/copy_or_download_file.rb b/providers/copy_or_download_file.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Providers:: copy_or_download_file

diff --git a/providers/delete_directory_by_link.rb b/providers/delete_directory_by_link.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Providers:: delete_directory_by_link

diff --git a/providers/run_jar_installer.rb b/providers/run_jar_installer.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Providers:: run_jar_installer

diff --git a/providers/run_tar_installer.rb b/providers/run_tar_installer.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Providers:: run_tar_installer

diff --git a/recipes/agents_package.rb b/recipes/agents_package.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Recipes:: agents_package

diff --git a/recipes/agents_package_uninstall.rb b/recipes/agents_package_uninstall.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Recipes:: agents_package_uninstall

diff --git a/recipes/apache_wsagent.rb b/recipes/apache_wsagent.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Recipes:: apache_wsagent

diff --git a/recipes/apache_wsagent_uninstall.rb b/recipes/apache_wsagent_uninstall.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Recipes:: apache_wsagent_uninstall

diff --git a/recipes/collector.rb b/recipes/collector.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Recipes:: collector
@@ -103,7 +105,7 @@
   service_name service
   # For Debian and Ubuntu distros - to correctly stop our service we need the status support which is disabled by default
   supports     :status => true
-  action       [:start, :enable]
+  action       %i[start enable]
 end
 
 ruby_block "Waiting for port #{agent_port} to become available" do

diff --git a/recipes/collector_uninstall.rb b/recipes/collector_uninstall.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Recipes:: collector_uninstall

diff --git a/recipes/default.rb b/recipes/default.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Recipes:: default

diff --git a/recipes/dotnet_agent.rb b/recipes/dotnet_agent.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Recipes:: dotnet_agent

diff --git a/recipes/dynatrace_user.rb b/recipes/dynatrace_user.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Recipes:: dynatrace_user

diff --git a/recipes/dynatrace_user_uninstall.rb b/recipes/dynatrace_user_uninstall.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Recipes:: dynatrace_user_uninstall

diff --git a/recipes/host_agent.rb b/recipes/host_agent.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Recipes:: host_agent
@@ -115,5 +117,5 @@
   service_name service_name
   # For Debian and Ubuntu distros - to correctly stop our service we need the status support which is disabled by default
   supports     :status => true
-  action [:enable, :start]
+  action %i[enable start]
 end
diff --git a/recipes/host_agent_uninstall.rb b/recipes/host_agent_uninstall.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Recipes:: host_agent_uninstall

diff --git a/recipes/iis_wsagent.rb b/recipes/iis_wsagent.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Recipes:: iis_wsagent

diff --git a/recipes/java.rb b/recipes/java.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Recipes:: java

diff --git a/recipes/java_agent.rb b/recipes/java_agent.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Recipes:: java_agent

diff --git a/recipes/memory_analysis_server.rb b/recipes/memory_analysis_server.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: dynatrace
 # Recipes:: memory_analysis_server
@@ -95,7 +97,7 @@
   service_name service
   # For Debian and Ubuntu distros - to correctly stop our service we need the status support which is disabled by default
   supports     :status => true
-  action       [:start, :enable]
+  action       %i[start enable]
 end
 
 ruby_block "Waiting for port #{server_port} to become available" do