This repository has been archived by the owner on Dec 11, 2023. It is now read-only.
Minor improvements #158
Merged
Minor improvements #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The token is not really used for the NodeController, so it's only for consistency.
| val, err := ExtractToken(secret, "key") | ||
| assert.Error(t, err) | ||
| assert.Empty(t, val) | ||
| // this case should ideally fail with "missing token X" error |
There was a problem hiding this comment.
you can add message arg to assert function call. These comments can be moved there, imo.
There was a problem hiding this comment.
Hmm, the comment would only appear when the check fails which don't think it's the intention here, right? This comment is more of a TODO.
There was a problem hiding this comment.
So this test is actually useless. Either change the validation logic in ExtractToken to check for empty strings or remove it.
There was a problem hiding this comment.
I'll just remove the comment. I personally find an empty string a valid response for non-specific Secret field getter, and the usual receiver, dynatrace_client.NewClient() already validates for empty strings anyway.
namratachaudhary
previously approved these changes
Oct 29, 2019
DTMad
previously approved these changes
Oct 30, 2019
DTMad
approved these changes
Oct 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small changes:
ExtractToken(formerlyGetToken) tests tooneagent-utilspackage.istio_integration_test.gofile name.