This repository has been archived by the owner on Dec 11, 2023. It is now read-only.
Use istio.io/client-go library to manage Istio objects #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DTMad
previously approved these changes
Nov 28, 2019
namratachaudhary
suggested changes
Nov 28, 2019
namratachaudhary
previously approved these changes
Nov 28, 2019
lrgar
force-pushed
the
feature/istio-client-go
branch
from
45ad422
to
83c577e
Compare
|
Rebased. Please re-approve. |
DTMad
approved these changes
Nov 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When first implemented, there was no official library we could use to create and manage the Istio objects for Kubernetes, so we generated our own and included it in our repository.
There is one now, https://github.com/istio/client-go, so this PR replaces the internal usage to this library.