This repository has been archived by the owner on Dec 11, 2023. It is now read-only.
Add Dockerfile based on UBI base image #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DTMad
previously approved these changes
Dec 4, 2019
|
Rebased from master. |
baichinger
approved these changes
Dec 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses an UBI-based Dockerfile for the Operator for both Quay and RHCC images.
The Dockerfile and the new helper files are from the template created by the operator-sdk v0.12 CLI, but I modified the
ubi-minimal:latest's tag to8.1instead.Note that there is now an
ENTRYPOINTinstruction on the Dockerfile, so no need to specify the command on the deployment manifests. (Although, curiously, the command field is still mentioned on the generated deployments from the operator-sdk)