This repository has been archived by the owner on Dec 11, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On this PR I'm refactoring when Marked for Termination events are going to be sent: rather than sending them when a node goes cordoned or deleted, we'll now only send them when deleted.
The reason is that a node being cordoned doesn't affect DaemonSets such as the OneAgent; they are still running, so the timings can be wrong.
So the idea here is to keep a cache of seen nodes in a ConfigMap on the dynatrace namespace (called it
dynatrace-node-cache
. I've modified the Nodes controller to run periodically every 5 minutes to check the current state and send events if a node on the cache doesn't exist anymore. I've also added the logic to recognize deletions from the Dynatrace API.As for additional notes,