Skip to content
This repository has been archived by the owner on Dec 11, 2023. It is now read-only.

Add ownership to Istio objects #217

Merged
merged 2 commits into from
Mar 17, 2020
Merged

Add ownership to Istio objects #217

merged 2 commits into from
Mar 17, 2020

Conversation

lrgar
Copy link
Contributor

@lrgar lrgar commented Mar 17, 2020

I'm adding the owner to Istio objects, so in case the corresponding OneAgent gets deleted, the generated Istio objects get deleted as well.

Additionally,

  • ReconcileIstio returns (bool, error) now. We weren't doing anything with the extra boolean.
  • Reduced the waiting time if ReconcileIstio succeeds. It exists only to give some time for Istio to recognize the extra ServiceEntry and VirtualService objects. 1min is perhaps overkill.

@lrgar lrgar requested a review from DTMad March 17, 2020 13:59
@lrgar lrgar merged commit dd8151d into master Mar 17, 2020
@lrgar lrgar deleted the bugfix/istio-owner branch March 23, 2020 16:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants