This repository has been archived by the owner on Dec 11, 2023. It is now read-only.
Update status of OneAgentAPM if token is missing #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrgar
reviewed
Aug 6, 2020
| name = "oneagent" | ||
| namespace = "dynatrace" | ||
|
|
||
| noTokenError = "Secret 'dynatrace:oneagent' not found" |
There was a problem hiding this comment.
If it's a variable used only once, then I suggest using it directly on the function who calls it.
| name := "oneagent" | ||
| ns := "dynatrace" | ||
| const ( | ||
| apiUrl = "https://ENVIRONMENTID.live.dynatrace.com/api" |
There was a problem hiding this comment.
apiURL please so that Go linter doesn't complain about it.
DTMad
approved these changes
Aug 6, 2020
lrgar
approved these changes
Aug 6, 2020
lrgar
pushed a commit
that referenced
this pull request
Aug 18, 2020
…tatus Update status of OneAgentAPM if token is missing
lrgar
pushed a commit
that referenced
this pull request
Aug 18, 2020
…tatus Update status of OneAgentAPM if token is missing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before returning the error, updates status of an OneAgentAPM instance if the token secret is missing.