This repository has been archived by the owner on Dec 11, 2023. It is now read-only.
add libc property #341
Merged
add libc property #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meik99
force-pushed
the
feature/libc-property
branch
from
77df505
to
ee86e0f
Compare
baichinger
reviewed
Nov 10, 2020
There was a problem hiding this comment.
Will this cause confusion when the user needs to know that annotation flavor is actually the same as custom resource field libc. It will get even more strange when values of them do not match: musl vs. default vs. glibc.
Therefore, shouldn't we simply stick with the term flavor?
deploy/cr-apm.yaml
Outdated
| # Optional: define which core library for C should be used. | ||
| # Can be set to "musl" to use musl instead of glibc | ||
| # | ||
| # libc: "musl" |
There was a problem hiding this comment.
Can it be set to glibc as well?
deploy/cr-apm.yaml
Outdated
| @@ -49,3 +50,8 @@ spec: | |||
| # limits: | |||
| # cpu: 500m | |||
| # memory: 100M | |||
|
|
|||
| # Optional: define which core library for C should be used. | |||
There was a problem hiding this comment.
Could be rephrased to "defines the C standard library used."
| // Optional: define which core library for C should be used. | ||
| // Can be set to "musl" to use musl instead of glibc | ||
| // +operator-sdk:gen-csv:customresourcedefinitions.specDescriptors=true | ||
| // +operator-sdk:gen-csv:customresourcedefinitions.specDescriptors.displayName="C Core Library" |
There was a problem hiding this comment.
Please use C standard library as well.
pkg/webhook/server/flavor.go
Outdated
Comment on lines
12
to
15
| if flavor != "musl" { | ||
| return "default" | ||
| } | ||
| return flavor |
There was a problem hiding this comment.
Suggested change
| if flavor != "musl" { | |
| return "default" | |
| } | |
| return flavor | |
| if flavor = "musl" { | |
| return flavor | |
| } | |
| return "default |
extended property description
lrgar
approved these changes
Nov 16, 2020
DTMad
approved these changes
Nov 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.