This repository has been archived by the owner on Dec 11, 2023. It is now read-only.
Migrate to operator-sdk 1.2 #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* starting webhook and bootstrapper with operator * implemented liveness and readiness probes for operator and bootstrapper * removed setting x-kubernetes-list-type edited makefile :all to include all .go files in root directory added comment to registerDebugInjectEndpoint
lrgar
reviewed
Dec 21, 2020
controllers/utils/utils.go
Outdated
| @@ -295,3 +296,23 @@ func GetField(values map[string]string, key, defaultValue string) string { | |||
| } | |||
| return defaultValue | |||
| } | |||
|
|
|||
| func GetPod(ctx context.Context, client client.Client, ns string) (*corev1.Pod, error) { | |||
There was a problem hiding this comment.
I'd be careful regarding (I presume) copy/pasting code from third-party libraries and license.
Just do the client.Get(... pod) command in GetDeployment. The rest here is not relevant for us.
* fixes for pr * increasing initial delay for probes to a minute
lrgar
reviewed
Jan 11, 2021
webhook/bootstrapper/controller.go
Outdated
| r.logger.Error(err, "could not start health endpoint for operator") | ||
| } | ||
|
|
||
| if err = mgr.AddReadyzCheck("healthz", healthz.Ping); err != nil { |
|
This won't be merged before the release of v0.9.4 |
lrgar
approved these changes
Jan 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.