Execution plan cleaner #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iNecas
requested changes
Aug 17, 2017
|
|
||
| def clean! | ||
| plans = @world.persistence.find_old_execution_plans(Time.now.utc - @max_age) | ||
| @world.persistence.delete_execution_plans(uuid: plans.map(&:id)) |
There was a problem hiding this comment.
Doesn't this have the issue with the blank filer on uuid => [] matching all the plans? I guess we should probably just fix this case directly in sequel persistence adapter, to avoid this issues in once and for all, as I don't see where it would actually be useful.
There was a problem hiding this comment.
Just tried it, looks it is safe to use now
There was a problem hiding this comment.
Ah, sry, my bad, I was trying it against find_execution_paln with wrong filter
adamruzicka
force-pushed
the
periodic-cleanup
branch
from
18870a6
to
4b70073
Compare
|
Added some tests, let's see how Mr. T likes them |
|
The tests are green |
iNecas
approved these changes
Aug 18, 2017
|
Tests speak for themselves: thanks @adamruzicka. Merging now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is disabled by default, needs to be enabled in a world's config. For the usage on smart-proxy this should be good to go since there's mostly one or two kinds of tasks (rex and ansible), so we probably don't need fine grained controls for setting different interval for different actions.