Fixes #20809 - Add interface for retrieving pending step counts #251
Conversation
lib/dynflow/web/console.rb
Outdated
| post('/worlds/pending_steps') do | ||
| @worlds = world.coordinator.find_worlds | ||
| @worlds.each do |w| | ||
| steps = world.get_pending_steps(w.data['id'], nil, 5).value!.values.sum |
There was a problem hiding this comment.
I'm getting NoMethodError at /worlds/pending_steps undefined method `sum' for []:Array when running pure dynflow, without Rails, as this methods comes from ActiveSupport
There was a problem hiding this comment.
Actually it was added to pure ruby in 2.4.0, will fix anyway.
lib/dynflow/dispatcher.rb
Outdated
| end | ||
|
|
||
| Response = Algebrick.type do | ||
| variants Accepted = atom, | ||
| Failed = type { fields! error: String }, | ||
| Done = atom, | ||
| Pong = atom | ||
| Pong = atom, | ||
| PendingSteps = type { fields! pending_steps: Hash } |
There was a problem hiding this comment.
I'm not sure if Steps is the best word, as it has already some meaning: the items there might be either steps or events for the steps: it would be more like execution items
There was a problem hiding this comment.
True, I'll try to come up with better name for it
adamruzicka
force-pushed
the
pending-steps
branch
from
67c0f80
to
84a85ce
Compare
|
API still pending |
|
Created separate issue for the API part |
| @@ -62,6 +71,12 @@ def start_termination(*args) | |||
| try_to_terminate | |||
| end | |||
|
|
|||
| def execution_items(execution_plan_id = nil) | |||
There was a problem hiding this comment.
Since we added more things than just the execution items. something more generic, such as execution_status or something like that would match more what it actually does
lib/dynflow/web/console.rb
Outdated
| @@ -37,6 +37,16 @@ class Console < Sinatra::Base | |||
| erb :worlds | |||
| end | |||
|
|
|||
| post('/worlds/execution_items') do | |||
There was a problem hiding this comment.
Again: Since we added more things than just the execution items. something more generic, such as execution_status or something like that would match more what it actually does.
lib/dynflow/web/console.rb
Outdated
| @@ -37,6 +37,16 @@ class Console < Sinatra::Base | |||
| erb :worlds | |||
| end | |||
|
|
|||
| post('/worlds/execution_items') do | |||
| @worlds = world.coordinator.find_worlds | |||
There was a problem hiding this comment.
We should limit this to active executors only (so find_worlds(true)) as no reason for reaching to the client worlds.
|
I don't want the PR to grow to much, there fore here are some post-merge ideas to continue:
Again: I'm ok with taking these outside of the PR, but would be great addition to the console regarding |
|
Those items would be definitely nice to have but will have to wait for another PR |
| else | ||
| { execution_plan_id => @jobs.fetch(execution_plan_id, []) } | ||
| end | ||
| source.reduce({}) { |acc, cur| acc.update(cur.first => cur.last.count) } |
There was a problem hiding this comment.
What about using destructuring assignment here?:
source.reduce({}) { |acc, (plan_id, work_items)| acc.update(plan_id => work_items.count) }
|
Tested and worked well. Thanks @adamruzicka |
No description provided.