Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagnose non-private nested methods #460

Closed
Clashsoft opened this issue Nov 25, 2018 · 0 comments
Closed

Diagnose non-private nested methods #460

Clashsoft opened this issue Nov 25, 2018 · 0 comments
Assignees
@Clashsoft
Labels
epic:Diagnostic Addition or changes to compiler diagnostics (errors and warnings) module:Compiler Implementation requires major changes to the compiler type:Feature New functionality
Milestone
v0.44.0

Comments

@Clashsoft
Copy link
Member

Add an error diagnostic for nested methods that are not private (no visibility modifier is ok since nested methods are implicitly private).
@Clashsoft Clashsoft added this to the v0.44.0 milestone Nov 25, 2018
@Clashsoft Clashsoft self-assigned this Nov 25, 2018
@Clashsoft Clashsoft added epic:Diagnostic Addition or changes to compiler diagnostics (errors and warnings) module:Compiler Implementation requires major changes to the compiler status:Scheduled Scheduled for the next release type:Feature New functionality status:In Progress Implementation in progress and removed status:Scheduled Scheduled for the next release labels Nov 25, 2018
Clashsoft added a commit that referenced this issue Nov 29, 2018
@Clashsoft
Diagnostic for non-private nested methods
7804682 
comp: Added an error diagnostic for non-private nested methods. #460
comp: Fixed trailing space in the `ModifierUtil.accessModifiersToString` result.

Closes #460
@Clashsoft Clashsoft removed the status:In Progress Implementation in progress label Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Clashsoft Clashsoft

Labels
epic:Diagnostic Addition or changes to compiler diagnostics (errors and warnings) module:Compiler Implementation requires major changes to the compiler type:Feature New functionality
Projects
None yet
Milestone
v0.44.0
Development

No branches or pull requests
1 participant
@Clashsoft