move utilities library and actually use it

E2OpenPlugins · Sep 9, 2017 · a846b76 · a846b76
1 parent e447d85
commit a846b76
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/plugin/controllers/file.py b/plugin/controllers/file.py
@@ -19,6 +19,8 @@
 
 from Components.config import config
 from Tools.Directories import fileExists
+from utilities import lenient_force_utf_8, sanitise_filename_slashes
+
 
 def new_getRequestHostname(self):
 	host = self.getHeader(b'host')
@@ -38,8 +40,8 @@ def render(self, request):
 			action = request.args["action"][0]
 
 		if "file" in request.args:
-			filename = request.args["file"][0].decode('utf-8', 'ignore').encode('utf-8')
-			filename = re.sub("^/+", "/", os.path.realpath(filename))
+			filename = lenient_force_utf_8(request.args["file"][0])
+			filename = sanitise_filename_slashes(os.path.realpath(filename))
 
 			if not os.path.exists(filename):
 				return "File '%s' not found" % (filename)

diff --git a/plugin/controllers/rest_fs_access.py b/plugin/controllers/rest_fs_access.py
@@ -43,11 +43,9 @@
 import twisted.web.static
 from twisted.web import http
 
+from utilities import MANY_SLASHES_REGEX
 import file
 
-MANY_SLASHES_PATTERN = r'[\/]+'
-MANY_SLASHES_REGEX = re.compile(MANY_SLASHES_PATTERN)
-
 #: default path from which files will be served
 DEFAULT_ROOT_PATH = os.path.abspath(os.path.dirname(__file__))
 

diff --git a/plugin/utilities.py → plugin/controllers/utilities.py b/plugin/utilities.py → plugin/controllers/utilities.py