Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch global ocean in init mode to E3SM shared constants #96

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented May 3, 2024

This merge also migrates the computation of the Coriolis parameter to using E3SM shared constants.

The unused constants module imports are removed from several init mode utilities to ensure that they don't use constants that are inconsistent with E3SM's versions.

I have make local symlinks to the shared constants and kinds file for convenience in building using MPAS-Ocean's not-very-sophisticated build system.

xylar added 2 commits May 3, 2024 15:45
This merge also migrates the computation of the coriolis parameter
to using E3SM shared constants.

The unused constants module imports are removed from several
init mode utilities to ensure that they don't use constants
that are inconsistent with E3SM's versions.
@xylar
Copy link
Collaborator Author

xylar commented May 3, 2024

@proteanplanet, this my proposed fix to E3SM-Project#6387. Please have a look, though I am fully aware that MPAS-Ocean init mode is nothing you have detailed knowledge about (nor should you!).

@mark-petersen, I know I'm asking a lot of you at a busy time but please give this a look when you can.

@xylar
Copy link
Collaborator Author

xylar commented May 3, 2024

Testing

I ran the pr suite on Chrysalis with Intel and OpenMPI using this branch, and using MPAS-Dev/compass#810 as a baseline (because this addresses recent non-BFB issue on Chrysalis).

Tests other than global ocean are BFB as expected. Global ocean forward runs show differences in T, S, layer thickness and velocity on the order of 1e-8 (so definitely not negligible).

@proteanplanet
Copy link
Collaborator

We should include a sea ice solution in this. I will take care of that this week.

@xylar
Copy link
Collaborator Author

xylar commented May 6, 2024

@proteanplanet, since these changes are specific to mpas-ocean standalone, we shouldn't mix them with E3SM changes to any component. We should take care of that in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants