Gustiness, tpert, wsubmin for EAMv2 #2679

polunma · 2019-01-09T16:08:16Z

This includes subgrid wind gustiness (ocean and land; ZM and clubb),
subgrid temperature (tpert), lower wsubmin for activation, and theta-v
formula fix. These code mods are controlled by namelist. EAMv1 is BFB.

[BFB]
[NML]

This includes subgrid wind gustiness (ocean and land; ZM and clubb), subgrid temperature (tpert), lower wsubmin for activation, and theta-v formula fix. These code mods are controled by namelist. EAMv1 is BFB.

rljacob

Need to replace some magic numbers.

components/cam/src/physics/cam/clubb_intr.F90

rljacob · 2019-01-09T17:38:38Z

components/cam/src/physics/cam/clubb_intr.F90

+        gust_fac(i)   = gust_faco
+      endif
+      vmag(i)         = max(1.e-5_r8,sqrt( umb(i)**2._r8 + vmb(i)**2._r8))
+      vmag_gust_dp(i) = ugust(min(prec_gust(i),6.94444e-4_r8),gust_fac(i))


6.94444e-4 is another "Magic number". Convert to a variable.

@rljacob It is a coefficient of the equation from the gustiness paper.

Comments are added to state that the numbers are coefficients of the empirical equation in Redelsperger et al. (2000).

rljacob · 2019-01-09T23:58:17Z

Will any of the current tests use this new gustiness paramaterization? If not, please add one that does.

singhbalwinder · 2019-01-10T00:48:59Z

Will any of the current tests use this new gustiness paramaterization? If not, please add one that does.

I will do that in a follow up PR.

components/cam/src/physics/cam/clubb_intr.F90

wlin7 · 2019-01-12T22:50:30Z

components/cam/src/physics/cam/clubb_intr.F90

-       thv(i) = th(i)*(1._r8+zvir*state%q(i,pver,ixq))  ! diagnose virtual potential temperature
+       if (eamv2) then
+         thv(i) = th(i)*(1._r8+zvir*state%q(i,pver,ixq) & ! PMA corrects virtual potential temperature formula
+                       - state%q(i,pver,ixcldliq))


need to get ixcldliq before using in this subroutine clubb_surface. thv fix in subroutine clubb_tend_cam is fine.

Done! Thanks for catching that! It was in my original code but got lost in this branch!

wlin7 · 2019-01-12T23:01:55Z

components/cam/src/physics/cam/physpkg.F90

+    call infld('vmag_gust', fh_ini, dim1name, dim2name, 1, pcols, begchunk, endchunk, &
+         tptr(:,:), found, gridname='physgrid')
+    if(.not. found) then
+       tptr(:,:) = 0._r8


I wonder how the assignment to tptr after calling infld and not found can take effect in the sequence of calls in this routine. Anyway, just for consistency, should it be set to 1.0 here?

The tptr is not used here. vmag_gust is initialized to 1.0.

I wonder if this part of code is necessary, since vmag_gust is always initialized in clubb_tend. There was a time when the code failed to compile, so I added this infld call.

wlin7 · 2019-01-12T23:07:20Z

components/cam/src/physics/cam/physpkg.F90

+       if (masterproc) write(iulog,*) 'vmag_gust initialized to 1.'
+    end if
+    vmag_gust_idx = pbuf_get_index( 'vmag_gust')
+    call pbuf_set_field(pbuf2d, vmag_gust_idx, 1._r8)


If eamv2=true, and vmag_gust available in ini file, should the input be retained? Here would always initialize vmag_gust to 1.0, regardless of eamv2 flag.

Yes I think the infld call might not be needed, since vmag_gust is initialized to 1 here. There was a time when the code failed to compile, so I added this infld call.

rljacob · 2019-01-14T04:24:09Z

How is this related to the gustiness param introduced in PR #1035 ?

singhbalwinder · 2019-01-14T22:04:01Z

How is this related to the gustiness param introduced in PR #1035 ?

@polunma : do you know if the old code mods (via PR #1035) are being used by the code in this PR in some way?

golaz · 2019-01-16T16:06:12Z

@polunma and @rljacob : I think it's a bad idea to have new variables named 'clubb_eamv2' and 'eamv2'. This is just going to make things more confusing in the future as we don't know yet what EAMv2 will look like. I would suggest to replace with more meaningful names and possible introduce more than one flag to be able to control new features individually.

polunma · 2019-01-16T21:06:46Z

@golaz the flag has been renamed!

polunma · 2019-01-16T21:30:07Z

@rljacob and @singhbalwinder , the old gustiness parameterization only has ZM component for ocean. This PR includes (1) ZM component, (2) CLUBB component), for both over land and over ocean. To make ZM component work over land, the code needs to be implemented in a different way. So, the old gustiness parameterization is not turned on, but this PR will handle all gustiness.

rljacob · 2019-01-23T00:21:30Z

Should we eventually remove the old gustiness param from the coupler?

golaz · 2019-01-23T15:33:00Z

@polunma : thanks for making the changes I suggested.
@rljacob : if it's not being used, we could eventually remove the old gustiness.

[BFB] - Bit-For-Bit [NML] - Namelist Changing See confluence for a more detailed description about these tags.

singhbalwinder · 2019-01-25T22:53:55Z

Hi @polunma : I have made some changes to the code. They are very minor. Would you please take a look to see if they are okay? Thanks!

Gustiness, tpert, wsubmin for EAMv2 This includes subgrid wind gustiness (ocean and land; ZM and clubb), subgrid temperature (tpert), lower wsubmin for activation, and theta-v formula fix. These code mods are controlled by namelist. EAMv1 is BFB. [BFB] [NML] * polunma/atm/eamv2: Adds some cosmetic changes and removes code which is not required Rename flag to use_sgv Add ixcldliq in clubb_surface Add comments for the numbers in the equation Gustiness, tpert, wsubmin for EAMv2

singhbalwinder · 2019-01-28T20:06:11Z

Merged to next.

The error was due to gust_fac being declared as an array and used as a scalar: /global/cscratch1/sd/bsingh/delete/tmp/gnu_compile/E3SM/components/cam /src/physics/cam/clubb_intr.F90:1253:30: real(r8) :: gust_fac(pcols) 1 Error: Argument 'gust_fac' of statement function at (1) must be scalar /global/cscratch1/sd/bsingh/delete/tmp/gnu_compile/E3SM/components/cam /src/physics/cam/clubb_intr.F90:1248:20: real(r8) :: ugust ! function: gustiness as a function of convective rainfall 1 Error: Incompatible ranks 0 and 1 in assignment at (1) /global/cscratch1/sd/bsingh/acme_scratch/cori-knl/SMS_Ln1.ne4_ne4. FC5AV1C-L.cori-knl_gnu.gnu_tst_del/Tools/Makefile:934: recipe for target 'clubb_intr.o' failed gmake: *** [clubb_intr.o] Error 1 [BFB] - Bit-For-Bit [NML] - Namelist Changing See confluence for a more detailed description about these tags.

Gustiness, tpert, wsubmin for EAMv2 This includes subgrid wind gustiness (ocean and land; ZM and clubb), subgrid temperature (tpert), lower wsubmin for activation, and theta-v formula fix. These code mods are controlled by namelist. EAMv1 is BFB. [BFB] [NML]

…thod-hang Automatically Merged using E3SM Pull Request AutoTester PR Title: Avoid recomputing min/max gids in grid clones PR Author: bartgol PR LABELS: AT: AUTOMERGE

Gustiness, tpert, wsubmin for EAMv2

251e302

This includes subgrid wind gustiness (ocean and land; ZM and clubb), subgrid temperature (tpert), lower wsubmin for activation, and theta-v formula fix. These code mods are controled by namelist. EAMv1 is BFB.

polunma assigned singhbalwinder Jan 9, 2019

polunma requested review from wlin7 and golaz January 9, 2019 16:08

rljacob requested changes Jan 9, 2019

View reviewed changes

Add comments for the numbers in the equation

67425fb

Comments are added to state that the numbers are coefficients of the empirical equation in Redelsperger et al. (2000).

rljacob approved these changes Jan 9, 2019

View reviewed changes

rljacob added the Atmosphere label Jan 9, 2019

singhbalwinder added the BFB PR leaves answers BFB label Jan 10, 2019

wlin7 reviewed Jan 12, 2019

View reviewed changes

components/cam/src/physics/cam/clubb_intr.F90 Outdated Show resolved Hide resolved

wlin7 reviewed Jan 12, 2019

View reviewed changes

Add ixcldliq in clubb_surface

33fba63

wlin7 approved these changes Jan 15, 2019

View reviewed changes

Rename flag to use_sgv

7f733eb

golaz approved these changes Jan 23, 2019

View reviewed changes

singhbalwinder added the NML label Jan 25, 2019

Adds some cosmetic changes and removes code which is not required

1cb8a84

[BFB] - Bit-For-Bit [NML] - Namelist Changing See confluence for a more detailed description about these tags.

singhbalwinder merged commit 288ee8c into master Jan 30, 2019

singhbalwinder mentioned this pull request Feb 1, 2019

Manually reverts gustiness changes from PRs #1035 and #1624 #2720

Merged

quantheory mentioned this pull request Jul 25, 2023

Confusion between scalar and vector stress calculations #5834

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gustiness, tpert, wsubmin for EAMv2 #2679

Gustiness, tpert, wsubmin for EAMv2 #2679

polunma commented Jan 9, 2019 •

edited by singhbalwinder

rljacob left a comment

rljacob Jan 9, 2019

polunma Jan 9, 2019

rljacob commented Jan 9, 2019

singhbalwinder commented Jan 10, 2019

wlin7 Jan 12, 2019

polunma Jan 15, 2019

wlin7 Jan 12, 2019 •

edited

polunma Jan 15, 2019

polunma Jan 15, 2019 •

edited

wlin7 Jan 12, 2019

polunma Jan 15, 2019

rljacob commented Jan 14, 2019

singhbalwinder commented Jan 14, 2019 •

edited by rljacob

golaz commented Jan 16, 2019

polunma commented Jan 16, 2019

polunma commented Jan 16, 2019

rljacob commented Jan 23, 2019

golaz commented Jan 23, 2019

singhbalwinder commented Jan 25, 2019

singhbalwinder commented Jan 28, 2019

Gustiness, tpert, wsubmin for EAMv2 #2679

Gustiness, tpert, wsubmin for EAMv2 #2679

Conversation

polunma commented Jan 9, 2019 • edited by singhbalwinder

rljacob left a comment

Choose a reason for hiding this comment

rljacob Jan 9, 2019

Choose a reason for hiding this comment

polunma Jan 9, 2019

Choose a reason for hiding this comment

rljacob commented Jan 9, 2019

singhbalwinder commented Jan 10, 2019

wlin7 Jan 12, 2019

Choose a reason for hiding this comment

polunma Jan 15, 2019

Choose a reason for hiding this comment

wlin7 Jan 12, 2019 • edited

Choose a reason for hiding this comment

polunma Jan 15, 2019

Choose a reason for hiding this comment

polunma Jan 15, 2019 • edited

Choose a reason for hiding this comment

wlin7 Jan 12, 2019

Choose a reason for hiding this comment

polunma Jan 15, 2019

Choose a reason for hiding this comment

rljacob commented Jan 14, 2019

singhbalwinder commented Jan 14, 2019 • edited by rljacob

golaz commented Jan 16, 2019

polunma commented Jan 16, 2019

polunma commented Jan 16, 2019

rljacob commented Jan 23, 2019

golaz commented Jan 23, 2019

singhbalwinder commented Jan 25, 2019

singhbalwinder commented Jan 28, 2019

polunma commented Jan 9, 2019 •

edited by singhbalwinder

wlin7 Jan 12, 2019 •

edited

polunma Jan 15, 2019 •

edited

singhbalwinder commented Jan 14, 2019 •

edited by rljacob