Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the land initial conditions for CMIP6 compset #2833

Closed

Conversation

bishtgautam
Copy link
Contributor

Adds the land/ocean mask for the existing land initial conditions to
only define a land initial condition file for appropriate resolutions.

[BFB]

Adds the land/ocean mask for the existing land initial conditions to
only define a land initial condition file for appropriate resolutions.

[BFB]
@bishtgautam bishtgautam added Land maint-1.0 PRs for or issues about maint-1.0 labels Apr 1, 2019
@bishtgautam
Copy link
Contributor Author

bishtgautam commented Apr 1, 2019

The changes in this PR are similar to the ones added by @jonbob in b4e57ed.

@singhbalwinder, This PR would make fix ./create_test SMS.ne30_ne30.F1850C5-CMIP6 --compiler intel -t inic_conds by not using a land initial condition file.

@bishtgautam
Copy link
Contributor Author

@cameronsmith1, I have added you as a reviewer because I was not sure whom should I ask to review the PR to make sure these changes don't break maint-1.0 for CMIP6 runs. Please feel to re-assign the review as you see fit. Thanks

@cameronsmith1
Copy link
Contributor

Hi Gautam. Sorry, the email notification got lost in my inbox. I am probably not the best person to check the impact on maint-1.0. Chris Golaz or Qi Tang would be good, if they have time.

Pinging @golaz and @tangq

@singhbalwinder
Copy link
Contributor

Thanks @cameronsmith1 . I just verified that the CMIP6 F compset works fine if we use this branch. @golaz and @tangq : Would you please take a look at this change to see if it looks good to you? Thanks!

@singhbalwinder
Copy link
Contributor

The code mods in this PR has already been merged in maint-1.0 via PR #2877 (Multiple mods for maint-1.0 to run compset F1850C5-CMIP6 and nbfb tests, hash: 722536b). I am closing this PR.

@bishtgautam bishtgautam deleted the bishtgautam/lnd/fix-cmip6-initial-conds branch April 25, 2019 20:41
jgfouca pushed a commit that referenced this pull request Jun 26, 2024
…bannar

Automatically Merged using E3SM Pull Request AutoTester
PR Title: improve docs banner message
PR Author: mahf708
PR LABELS: AT: AUTOMERGE, documentation, AT: Integrate Without Testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Land maint-1.0 PRs for or issues about maint-1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants