Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor build fixes #2864

Merged
merged 1 commit into from
Apr 24, 2019
Merged

Minor build fixes #2864

merged 1 commit into from
Apr 24, 2019

Conversation

jgfouca
Copy link
Member

@jgfouca jgfouca commented Apr 16, 2019

Need consistent case for USE_CXX in Makefile (Restores cxxlib flag for PIO2). Intel should
not add qopenmp unless compile_threaded is TRUE.

Fixes #2858

[BFB]

Need consistent case for USE_CXX in Makefile. Intel should
not add qopenmp unless compile_threaded is TRUE.
@jgfouca jgfouca self-assigned this Apr 16, 2019
@jgfouca jgfouca added CIME BFB PR leaves answers BFB labels Apr 16, 2019
@dqwu
Copy link
Contributor

dqwu commented Apr 16, 2019

@jgfouca
Could you please consider updating the PR text?

  1. It fixes issue 2858
  2. It also restores missing cxxlib flag (for PIO2)

@jgfouca
Copy link
Member Author

jgfouca commented Apr 16, 2019

@dqwu done.

jgfouca added a commit that referenced this pull request Apr 22, 2019
Minor build fixes

Need consistent case for USE_CXX in Makefile (Restores cxxlib flag for
PIO2). Intel should not add qopenmp unless compile_threaded is TRUE.

Fixes #2858

[BFB]

* origin/jgfouca/cime/minor_compiler_fixes:
  Minor build fixes
@jgfouca
Copy link
Member Author

jgfouca commented Apr 22, 2019

Merged to next.

@jgfouca jgfouca merged commit ea16547 into master Apr 24, 2019
jgfouca added a commit that referenced this pull request Apr 24, 2019
Minor build fixes

Need consistent case for USE_CXX in Makefile (Restores cxxlib flag for
PIO2). Intel should not add qopenmp unless compile_threaded is TRUE.

Fixes #2858

[BFB]

* origin/jgfouca/cime/minor_compiler_fixes:
  Minor build fixes
@jgfouca jgfouca deleted the jgfouca/cime/minor_compiler_fixes branch April 24, 2019 16:46
jgfouca added a commit that referenced this pull request Jun 25, 2019
Minor build fixes

Need consistent case for USE_CXX in Makefile (Restores cxxlib flag for
PIO2). Intel should not add qopenmp unless compile_threaded is TRUE.

Fixes #2858

[BFB]

* origin/jgfouca/cime/minor_compiler_fixes:
  Minor build fixes
jgfouca pushed a commit that referenced this pull request Jun 26, 2024
…tive-ml/20240611_fix

Automatically Merged using E3SM Pull Request AutoTester
PR Title: Aarondonahue/corrective ml/20240611 fix
PR Author: AaronDonahue
PR LABELS: AT: AUTOMERGE, bugfix, AT: Skip Stand-Alone Testing, AT: Skip v1 Testing, machine learning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB CIME
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected flags in PIO2 build log on Cori
2 participants