Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create F2010 LR CMIP6 compset #2872

Merged
merged 9 commits into from
Apr 25, 2019
Merged

Create F2010 LR CMIP6 compset #2872

merged 9 commits into from
Apr 25, 2019

Conversation

tangq
Copy link
Contributor

@tangq tangq commented Apr 20, 2019

This PR create the F2010 LR compset with CMIP6 forcings.

@tangq tangq added compset maint-1.0 PRs for or issues about maint-1.0 labels Apr 20, 2019
@rljacob
Copy link
Member

rljacob commented Apr 20, 2019

@tangq please update the description to remove links to confluence and the path name. You can add that material in comments under the description. In the PR description, just use words or you can reference other hashes in the repo.

@wlin7
Copy link
Contributor

wlin7 commented Apr 23, 2019

All looks good, @tangq . Do need your confirmation on:

  1. aerosol forcing and emission files use those from 20TRC5-CMIP6 compset. Is it intended. I know it is documented so on the confluence; and they are different from what are currently used for F20TRC5-CMIP6-HR.

  2. Have you tested that the specified finitdat and fsurdat can work together, even with consistency check?

@wlin7 wlin7 self-assigned this Apr 23, 2019
@tangq
Copy link
Contributor Author

tangq commented Apr 23, 2019

The 1-day test run is successful and located at /global/cscratch1/sd/tang30/E3SM_simulations/edison.20190415_maint-1.0.tst_F2010C5-CMIP6-LR.ne30_oECv3

@tangq
Copy link
Contributor Author

tangq commented Apr 23, 2019

Hi @wlin7 , to answer your questions:

  1. It seems to me that for the same grids, the F1850, F2010, and F20TR should use consistent aerosol files, so I use the year 2010 slice of the F20TR aerosol files. Different HR and LR aerosol files are related to the fact that obs4mips provides different aerosol raw files for CMIP6 HR and LR runs.
  2. In my 1-day test above, I didn't turn off the consistency check. In the lnd log file, the following session confirms that this check is on.
    finidat_consistency_checks settings:
    &FINIDAT_CONSISTENCY_CHECKS
    CHECK_FINIDAT_FSURDAT_CONSISTENCY = T,
    CHECK_FINIDAT_YEAR_CONSISTENCY = T,
    CHECK_FINIDAT_PCT_CONSISTENCY = T
    /

@wlin7
Copy link
Contributor

wlin7 commented Apr 24, 2019

Thanks for the reply, @tangq . The spec for aerosol files are reasonable. Do you want @PeterCaldwell and @golaz to also review and approve this PR? I can start merging this PR to maint-1.0 anytime.

Copy link
Contributor

@PeterCaldwell PeterCaldwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. I agree we should use the low-res (aka CMIP6 DECK) aerosol files here.

One really dumb, sanity check question: we're using low-res tuning parameters here rather than "LRtunedHR", right? I think that's the correct thing to do because otherwise the compset name would be misleading...

Copy link
Contributor

@golaz golaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tangq: thanks for working on this. This will be a very useful compset to have. The changes look fine to me.

I have only a minor concern about the naming convention (aliases) of the CMIP6 compsets:

F1850C5-CMIP6
F1850SC5-CMIP6
F20TRC5-CMIP6
F2010C5-CMIP6-LR

I don't know if the average user will be able to understand what they mean. If it is possible to have multiple aliases for the same compset (?), maybe we should add a new more meaningful naming convention without removing the old one (and breaking compatibility).

@tangq
Copy link
Contributor Author

tangq commented Apr 24, 2019

@PeterCaldwell , you are right. This compset is the "real" low-res compset, not with HR tuning.

@tangq
Copy link
Contributor Author

tangq commented Apr 24, 2019

@golaz , I agree that we need a better compset naming convention. When creating this compset, I followed the old convention. We can switch to the new one (when established) later.

Thank you all for checking and making sure the settings are correct.

@wlin7 , looks like this PR is ready to be merged. Thanks.

@PeterCaldwell
Copy link
Contributor

@golaz makes a good point that our compset names don't make logical sense, but I agree with Qi that we shouldn't change the convention in this PR... we should change all names in a future PR.
In particular, doesn't "c5" stand for "CAM5"? That's kind of awkward...

@golaz
Copy link
Contributor

golaz commented Apr 24, 2019

@rljacob : is it possible to have multiple aliases point to the same compset? If so, that would make it easier to come up with a better naming convention later without breaking previous configurations?

@wlin7 wlin7 merged commit f590194 into maint-1.0 Apr 25, 2019
wlin7 added a commit that referenced this pull request Apr 25, 2019
This PR create the F2010 LR compset with CMIP6 forcings.

[BFB]
@golaz
Copy link
Contributor

golaz commented Apr 25, 2019

@tangq and @wlin7 : thanks for all the work on this.
Can we also have the new CMIP6 compsets on master?

@wlin7
Copy link
Contributor

wlin7 commented Apr 25, 2019

Merged to maint-1.0.

@golaz, it is a good idea for using multiple aliases when switching to a new naming convention while keeping the existing one. Logically it should be fully supported to have multiple aliases pointing to the same compset. I just did a test anyway using this LR compset and confirmed it.

BTW, reminded by @PeterCaldwell 's comments, even many of the longnames for the compsets carry the tag of "CAM5". We may one day need to change that as well.

@golaz
Copy link
Contributor

golaz commented Apr 25, 2019

@wlin7, thanks for trying out. We could start by having multiple aliases but I agree with you and @PeterCaldwell that a long name with CAM5 in it doesn't make much sense any longer. I don't know how disruptive it would be to try to remedy this.

@wlin7
Copy link
Contributor

wlin7 commented Apr 25, 2019

@golaz , we can start to work to get these CMIP6 compsets on master. The F2010 HR compset still needs some update. After that, we can have a PR to include all the new compsets. We need a new branch that is based off the master, because merging the ones based off maint-1.0 may have issues.

@tangq
Copy link
Contributor Author

tangq commented Apr 25, 2019

@wlin7 , the F2010 HR compset is waiting for the finial evaluation of its performance. I already did a 5-year run (/global/cscratch1/sd/tang30/E3SM_simulations/cori-knl.20190214_maint-1.0.F2010C5-CMIP6-HR.dailySST.ne120_oRRS18v3). @PeterCaldwell will ask more people to take a look. If the results look good, I will finalize it.

@wlin7
Copy link
Contributor

wlin7 commented Apr 25, 2019

@golaz , as we can see from the files changed, changing CAM5 to a new name will affect the config_compsets, config_component files, and the name of the use_case files. The number of files affected is limited. The patterns are well defined. Once we decide on the new name, I should be able to write a script to automatically change them all.

@tangq tangq deleted the tangq/atm/F2010-LR-compset branch May 28, 2019 00:26
rljacob pushed a commit that referenced this pull request Apr 12, 2021
This PR create the F2010 LR compset with CMIP6 forcings.

[BFB]
rljacob pushed a commit that referenced this pull request Apr 21, 2021
This PR create the F2010 LR compset with CMIP6 forcings.

[BFB]
jgfouca pushed a commit that referenced this pull request Jun 26, 2024
…io-v1.6.4

Automatically Merged using E3SM Pull Request AutoTester
PR Title: Updating to SCORPIO v1.6.4
PR Author: jayeshkrishna
PR LABELS: BFB, I/O, AT: AUTOMERGE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compset maint-1.0 PRs for or issues about maint-1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants