-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create F2010 LR CMIP6 compset #2872
Conversation
@tangq please update the description to remove links to confluence and the path name. You can add that material in comments under the description. In the PR description, just use words or you can reference other hashes in the repo. |
All looks good, @tangq . Do need your confirmation on:
|
The 1-day test run is successful and located at /global/cscratch1/sd/tang30/E3SM_simulations/edison.20190415_maint-1.0.tst_F2010C5-CMIP6-LR.ne30_oECv3 |
Hi @wlin7 , to answer your questions:
|
Thanks for the reply, @tangq . The spec for aerosol files are reasonable. Do you want @PeterCaldwell and @golaz to also review and approve this PR? I can start merging this PR to maint-1.0 anytime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me. I agree we should use the low-res (aka CMIP6 DECK) aerosol files here.
One really dumb, sanity check question: we're using low-res tuning parameters here rather than "LRtunedHR", right? I think that's the correct thing to do because otherwise the compset name would be misleading...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tangq: thanks for working on this. This will be a very useful compset to have. The changes look fine to me.
I have only a minor concern about the naming convention (aliases) of the CMIP6 compsets:
F1850C5-CMIP6
F1850SC5-CMIP6
F20TRC5-CMIP6
F2010C5-CMIP6-LR
I don't know if the average user will be able to understand what they mean. If it is possible to have multiple aliases for the same compset (?), maybe we should add a new more meaningful naming convention without removing the old one (and breaking compatibility).
@PeterCaldwell , you are right. This compset is the "real" low-res compset, not with HR tuning. |
@golaz , I agree that we need a better compset naming convention. When creating this compset, I followed the old convention. We can switch to the new one (when established) later. Thank you all for checking and making sure the settings are correct. @wlin7 , looks like this PR is ready to be merged. Thanks. |
@golaz makes a good point that our compset names don't make logical sense, but I agree with Qi that we shouldn't change the convention in this PR... we should change all names in a future PR. |
@rljacob : is it possible to have multiple aliases point to the same compset? If so, that would make it easier to come up with a better naming convention later without breaking previous configurations? |
This PR create the F2010 LR compset with CMIP6 forcings. [BFB]
Merged to maint-1.0. @golaz, it is a good idea for using multiple aliases when switching to a new naming convention while keeping the existing one. Logically it should be fully supported to have multiple aliases pointing to the same compset. I just did a test anyway using this LR compset and confirmed it. BTW, reminded by @PeterCaldwell 's comments, even many of the longnames for the compsets carry the tag of "CAM5". We may one day need to change that as well. |
@wlin7, thanks for trying out. We could start by having multiple aliases but I agree with you and @PeterCaldwell that a long name with CAM5 in it doesn't make much sense any longer. I don't know how disruptive it would be to try to remedy this. |
@golaz , we can start to work to get these CMIP6 compsets on master. The F2010 HR compset still needs some update. After that, we can have a PR to include all the new compsets. We need a new branch that is based off the master, because merging the ones based off maint-1.0 may have issues. |
@wlin7 , the F2010 HR compset is waiting for the finial evaluation of its performance. I already did a 5-year run (/global/cscratch1/sd/tang30/E3SM_simulations/cori-knl.20190214_maint-1.0.F2010C5-CMIP6-HR.dailySST.ne120_oRRS18v3). @PeterCaldwell will ask more people to take a look. If the results look good, I will finalize it. |
@golaz , as we can see from the files changed, changing CAM5 to a new name will affect the config_compsets, config_component files, and the name of the use_case files. The number of files affected is limited. The patterns are well defined. Once we decide on the new name, I should be able to write a script to automatically change them all. |
This PR create the F2010 LR compset with CMIP6 forcings. [BFB]
This PR create the F2010 LR compset with CMIP6 forcings. [BFB]
…io-v1.6.4 Automatically Merged using E3SM Pull Request AutoTester PR Title: Updating to SCORPIO v1.6.4 PR Author: jayeshkrishna PR LABELS: BFB, I/O, AT: AUTOMERGE
This PR create the F2010 LR compset with CMIP6 forcings.