Adds climate driven planting date for crops #2999
Conversation
Fixes the dynamic landunit bug that won't allow crops to be planted if they weren't on the grid cell previously [Non-BFB] - Non Bit-For-Bit (but only for the crop model)
Introduces a new method to calculate crop planting dates. Calculates the temperature or precipitation seasonality of a grid and determines planting date from temperature or precipitation thresholds. Therefore, the growing season is either the warm or wet season. This allows crops to grow globally, rather than in just the temperate latitudes. A new module, CropMod is added to support some of the calculations and will serve as a home of future crop model developments that are specific to crops. The parameter file is not changed as there are no new parameters. [Non-BFB] - Non Bit-For-Bit (only for the crop model) See confluence for a more detailed description about these tags.
|
The design document can be found at: https://acme-climate.atlassian.net/wiki/spaces/ED/pages/994934933/B5+Crop+Plant+Date+Design+Document |
|
The baseline comparison tests for e3sm_land_developer all pass on anvil, with the exception of the error TPUTCOMP Error: Computation time increase > 10 pct from baseline, which I was told to ignore. |
|
@bbye Is the new physics covered by the existing crop test? Or, do we need to add an additional test for the new physics? |
|
The current test will be fine. Once the surface datasets are updated I can create an additional test that would be a more thorough check, but that's not necessary. |
minor editrs to switch some local parameters to global parameters for the crop plant date calculation [Non-BFB] - Non Bit-For-Bit (only for crop model)
There was a problem hiding this comment.
@bbye Thanks for the changes. The PR is good to go and is pending code-review approval.
|
I see an approved data on June 18 here: https://acme-climate.atlassian.net/wiki/spaces/ED/pages/994934933/B4+Crop+Plant+Date+Design+Document @kvcalvin you approved it right? |
|
I did approve the design document. Is there something else I need to approve? |
|
@rljacob, Do we also need to approval for verification, performance, and validation tasks before we integrate v2 PRs? see https://acme-climate.atlassian.net/wiki/spaces/ED/pages/995426324/B4+Crop+Plant+Date |
Port to new cgd system izumi Test suite: scripts_regression_tests.py Test baseline: Test namelist changes: Test status: Fixes User interface changes?: Update gh-pages html (Y/N)?: Code review:
|
Reassigning to balance the integrator workload |
|
@bbye energyflux_vars was added in subroutine "CNPhenology", in order to be used in "CropPlantDate". However, it seems that energyflux_vars is never used in "CropPlantDate"？ Am I understanding this correctly? Is energyflux_vars redundant? |
|
I think I see what happened. The variable I used from the energyflux_vars is defined in both EnergyFluxMod and VegetationDataType. When I switched to use veg_ef I didn't remove the energyflux_vars. I can fix this. But, does anyone know why many of the energyflux_vars are allocated in two subroutines? |
removed the energyflux_vars [Non-BFB] - Non Bit-For-Bit (crop model only)
|
@thorntonpe @qzhu-lbl can you approve this PR? |
Adds climate driven planting date for crops Introduces a new method to calculate crop planting dates. Calculates the temperature or precipitation seasonality of a grid and determines planting date from temperature or precipitation thresholds. Therefore, the growing season is either the warm or wet season. This allows crops to grow globally, rather than in just the temperate latitudes. A new module, CropMod is added to support some of the calculations and will serve as a home of future crop model developments that are specific to crops. The parameter file is not changed as there are no new parameters. Also, fixes the dynamic landunit bug that won't allow crops to be planted if they weren't on the grid cell previously. Fixes #2962 [Non-BFB] - Non Bit-For-Bit (only for the crop model)
|
Merged to next. |
|
There were no diffs in the only crop test: SMS_Ly2_P1x1.1x1_smallvilleIA.ICLM45CNCROP.sandiatoss3_intel.clm-force_netcdf_pio Is that expected? |
|
Yes, that is expected. The changes are minor for the temperature threshold, which is the case for the crop test. In other grid cells there will be changes. In a future PR I will update the parameter file with new values for temperature thresholds that will result in diffs, but I can't do that until #2992 and #2995 are fixed. |
Adds climate driven planting date for crops Introduces a new method to calculate crop planting dates. Calculates the temperature or precipitation seasonality of a grid and determines planting date from temperature or precipitation thresholds. Therefore, the growing season is either the warm or wet season. This allows crops to grow globally, rather than in just the temperate latitudes. A new module, CropMod is added to support some of the calculations and will serve as a home of future crop model developments that are specific to crops. The parameter file is not changed as there are no new parameters. Also, fixes the dynamic landunit bug that won't allow crops to be planted if they weren't on the grid cell previously. Fixes #2962 [Non-BFB] - Non Bit-For-Bit (only for the crop model)
|
Merged #2999 |
Introduces a new method to calculate crop planting dates. Calculates the
temperature or precipitation seasonality of a grid and determines planting
date from temperature or precipitation thresholds. Therefore, the growing
season is either the warm or wet season. This allows crops to grow globally,
rather than in just the temperate latitudes.
A new module, CropMod is added to support some of the calculations and
will serve as a home of future crop model developments that are specific
to crops. The parameter file is not changed as there are no new parameters.
Also, fixes the dynamic landunit bug that won't allow crops to be planted
if they weren't on the grid cell previously.
Fixes #2962
[Non-BFB] - Non Bit-For-Bit (only for the crop model)