Add water management and inundation models to MOSART #3012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishtgautam
requested changes
Jun 25, 2019
components/mosart/bld/namelist_files/namelist_defaults_mosart.xml
Outdated
Show resolved
Hide resolved
jgfouca
pushed a commit
that referenced
this pull request
Jun 25, 2019
Fischer/ect doc This is just a copy of the Ensemble Consistency Test README file being used for the cime documentation. Test suite: Test baseline: Test namelist changes: Test status: [bit for bit, roundoff, climate changing] Fixes [CIME Github issue #] #1294 User interface changes?: Update gh-pages html (Y/N)?: Y Code review: bertinia
bishtgautam
requested changes
Aug 1, 2019
|
@hydrotian you need to make the change requested by @bishtgautam above. |
|
SBeTR module has been reverted and this PR is ready now. |
bishtgautam
approved these changes
Aug 8, 2019
bishtgautam
added a commit
that referenced
this pull request
Aug 8, 2019
Add water management and inundation models to MOSART. [BFB]
The namelist inund_inparm needs to be defined irrespective of inundflag = .true./.false.
bishtgautam
added a commit
that referenced
this pull request
Aug 9, 2019
Fixes the incorrect conflict resolution while merging PR #3012
bishtgautam
added a commit
that referenced
this pull request
Aug 9, 2019
Add water management and inundation models to MOSART. [BFB]
jqyin
added a commit
that referenced
this pull request
Aug 12, 2019
Add water management and inundation models to MOSART [BFB] Conflicts: components/mosart/cime_config/buildlib
|
Merged #3012 |
amametjanov
reviewed
Aug 16, 2019
| else | ||
| call t_startf('mosartr_euler') | ||
| ! debug | ||
| write(iulog,*) 'clm-mosart subT: (call Euler) ns=', ns |
There was a problem hiding this comment.
Please comment out or surround this line with #ifndef NDEBUG ... #endif to activate it for debug runs. A 5-day run produced 122721 writes to e3sm.log.
There was a problem hiding this comment.
@amametjanov open an issue about this. Assign it to @hydrotian
amametjanov
reviewed
Aug 16, 2019
| if (dd1 /= dd0) new_day = .true. | ||
| endif | ||
| endif | ||
| write(iulog,'(2a,4i6,3l4)') sub," yy,mm,dd = ",yy1,mm1,dd1,tod1,new_year,new_month,new_day |
There was a problem hiding this comment.
Please comment out or surround this write with #ifndef NDEBUG ... #endif.
dqwu
added a commit
that referenced
this pull request
Sep 9, 2019
The starts/counts for puts where the vars (1d/2d/3d) had no time dimensions were wrong, i.e., always had an extra start/count corresponding to the time dimension. Now we have the starts/counts for time dimension only when the var is supposed to have multiple timesteps. This fix (part of PR #2772) was accidentally reverted by PR #3012.
This was referenced Sep 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add water management and inundation models to MOSART.
[BFB]