Update MALI to use new Albany basal friction law #3032
Conversation
matthewhoffman
force-pushed
the
matthewhoffman/mali/update_basal_friction
branch
from
9b178a6
to
4afb439
Compare
|
Is this really BFB? even with an ice-sheet test? |
|
@rljacob , no, this is only BFB for "standard" compsets that do not include active ice sheets. I've updated the description to be more explicit - it wasn't clear to me how to handle this sort of situation. |
|
If its non-BFB for any test or case, I like to label the PR as non-BFB but you can add a comment with details as you did above. When we later search for non-BFB PRs, its good to have ones with any change included. |
|
Is this a v2 feature? If so, it needs a code review document on confluence. |
|
@matthewhoffman - I think this PR will require a code review document |
matthewhoffman
force-pushed
the
matthewhoffman/mali/update_basal_friction
branch
from
4afb439
to
1c01388
Compare
This commit updates MPAS source code to use the updated basal friction law from Albany. This is a Schoof-type basal friction law that accounts for subglacial water pressure. [Non-BFB] for compsets with active MALI component [NML]
matthewhoffman
force-pushed
the
matthewhoffman/mali/update_basal_friction
branch
from
89b09fe
to
a6ced9d
Compare
|
A MALI test is included in the e3sm_integration suite, which is tested for baselines on sandiatoss3 and for machine coverage on anvil, compy, bebop and theta. Note that the MALI test currently passes only on sandiatoss3 and bebop. This PR updates the version of MALI on sandiatoss3 and cori, so for purposes of testing I've focused on cori. A test merge shows these results:
@rljacob - we would still like to merge this PR today. MALI is not part of any upcoming simulation plans, so its absence on some platforms will not hold up progress. |
|
Go ahead. |
…#3032) Update MALI to use new Albany basal friction law This merge updates MPAS source code to use the updated basal friction law from Albany. This is a Schoof-type basal friction law that accounts for subglacial water pressure. [NML] [BFB] for compsets without active ice sheet [Non-BFB] for compsets with active MALI component
|
merged to next |
Update MALI to use new Albany basal friction law This merge updates MPAS source code to use the updated basal friction law from Albany. This is a Schoof-type basal friction law that accounts for subglacial water pressure. [NML] [BFB] for compsets without active ice sheet [Non-BFB] for compsets with active MALI component
|
merged to master and expected NML DIFF's blessed |
This merge updates MPAS source code to use the updated basal friction
law from Albany. This is a Schoof-type basal friction law that accounts
for subglacial water pressure.
[BFB] for compsets without active ice sheet
[Non-BFB] for compsets with active MALI component
[NML]